Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHDEVDOCS-3000 Document: Build Resource Volume Mounts #37205

Merged
merged 1 commit into from Oct 13, 2021
Merged

RHDEVDOCS-3000 Document: Build Resource Volume Mounts #37205

merged 1 commit into from Oct 13, 2021

Conversation

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 7, 2021
@netlify
Copy link

netlify bot commented Oct 7, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: c2a1ad0

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6166e377b347f200089cbea8

😎 Browse the preview: https://deploy-preview-37205--osdocs.netlify.app

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 7, 2021
@coreydaley
Copy link
Member

/assign @coreydaley

modules/builds-docker-strategy.adoc Outdated Show resolved Hide resolved
modules/builds-input-secrets-configmaps.adoc Outdated Show resolved Hide resolved
@coreydaley
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2021
cicd/builds/build-strategies.adoc Show resolved Hide resolved
modules/builds-source-input-satellite-config.adoc Outdated Show resolved Hide resolved
modules/builds-using-build-volumes.adoc Show resolved Hide resolved
modules/builds-using-build-volumes.adoc Outdated Show resolved Hide resolved
@missmesss
Copy link

@rolfedh I only had a couple of tiny language questions/nitpicks, they don't affect anything, so I've approved the changes straightaway.

@rolfedh
Copy link
Contributor Author

rolfedh commented Oct 13, 2021

a couple of tiny language questions/nitpicks, they don't affect anything, so I've approved the changes straightaway.

Thank you, @missmesss. Very helpful! I've applied the suggestions or provided some additional information that might be helpful.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2021
@jitendar-singh
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2021
@abrennan89 abrennan89 added this to the Future Release milestone Oct 13, 2021
@abrennan89 abrennan89 merged commit 693ec0e into openshift:main Oct 13, 2021
@abrennan89
Copy link
Contributor

/cherrypick enterprise-4.9

@openshift-cherrypick-robot

@abrennan89: new pull request created: #37440

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.9 lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants