New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[virt] Adding CNV docs to OKD #37215
Conversation
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: 323e10b97cf71169e1e9191374a14e95a62a1c0a 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/615f3d340c6f2600082ec17a 😎 Browse the preview: https://deploy-preview-37215--osdocs.netlify.app |
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: 97ffc1ef6e084646563a914885dfa947a53d1710 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/615f3d54f36def000814b498 😎 Browse the preview: https://deploy-preview-37215--osdocs.netlify.app |
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: cd0c22e 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/615f4011569b180008647510 😎 Browse the preview: https://deploy-preview-37215--osdocs.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
@ILpinto: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for taking this on, Pan!
/cherrypick enterprise-4.9 |
@ousleyp: #37215 failed to apply on top of branch "enterprise-4.9":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR adds the CNV docs to the openshift-origin distro and changes the top-level ToC label to "Virtualization" to avoid "OpenShift" appearing in OKD (or vice versa). Similarly, the "Installing OpenShift Virtualization" ToC label is now "Installing" (which matches OpenShift).
There is now an ifdef statement in the virt-document-attributes file so that
{VirtProductName}
renders as "OKD Virtualization" in the openshift-origin distro.Most changes originate from this PR by @sandrobonazzola: OKD: Add Virtualization documentation #36612
CP to enterprise-4.9
QE approved; needs peer review
Note: Netlify does not do an openshift-origin preview build. You can view the changes pertaining to openshift-enterprise here. I uploaded a preview build for the OKD changes, which you can view here: http://file.rdu.redhat.com/pousley/101221/okd-virt-docs/welcome/