BZ190696: Add warning about protracted boot time with no feedback #37233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
size/XS
|
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: f26acf0 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6166f4a97120b5000892daec 😎 Browse the preview: https://deploy-preview-37233--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal_ipi/ipi-install-prerequisites |
tmulquee
force-pushed
the
bz190696_bug
branch
from
2bb7c0a
to
1d146ea
Compare
ctauchen
reviewed
Oct 13, 2021
There was a problem hiding this comment.
Looks good @tmulquee. A few suggestions below.
But first:
- please edit your title to fit the format "BZ999999: descriptive title"
- does this really apply only to
enterprise-4.8? If so, you'll need to base your feature branch on 4.8 and merge only to 4.8
|
|
||
| [WARNING] | ||
| ==== | ||
| Boot times can take up to 10 minutes without any indication of progress. Do not assume the boot is stuck, or abort or reboot during this installation, as this could require troubleshooting on the next installation. |
There was a problem hiding this comment.
Suggested change
| Boot times can take up to 10 minutes without any indication of progress. Do not assume the boot is stuck, or abort or reboot during this installation, as this could require troubleshooting on the next installation. | |
| Boot times can take up to 10 minutes without any indication of progress. Do not cancel the installation or restart during this period because this could require troubleshooting on the next installation. |
A suggested rewrite, for clarity and to remove terms 'reboot', 'abort', 'as' (see ISG glossary).
There was a problem hiding this comment.
Thanks for the feedback, Chris, update applied.
There was a problem hiding this comment.
PR description updated as requested.
tmulquee
changed the title
More specific destails on BZ190696 Minor edits for BZ190696
tmulquee
force-pushed
the
bz190696_bug
branch
from
1d146ea
to
f26acf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1960696
Added Warning: Boot times are protracted without any indication of progress. Do not assume the boot is stuck, or abort or reboot during this installation.
Merge to enterprise-4.8.
Browse to preview: https://deploy-preview-37233--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal_ipi/ipi-install-prerequisites?utm_source=github&utm_campaign=bot_dp#ipi-install-firmware-requirements-for-installing-with-virtual-media_ipi-install-prerequisites
SME feedback: The new wording is better IMHO. This way the deploying person(s) won't way for hours/days to start debugging.
Thanks! (Full details in the BZ)