OSDOCS-2654: Added a missing name flag to the rosa CLI commands. #37409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
size/XS
|
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: 3b2374f 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6165dae0aced2e0007ecb5b2 😎 Browse the preview: https://deploy-preview-37409--osdocs.netlify.app/openshift-rosa/latest/nodes/rosa-managing-worker-nodes |
EricPonvelle
added
branch/dedicated
peer-review-needed
|
/lgtm Does this need QE? |
EricPonvelle
added
peer-review-done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing
--name=flag to two rosa CLI commands. Without this flag, the commands failed.JIRA: https://issues.redhat.com/browse/OSDOCS-2654
Preview: https://deploy-preview-37409--osdocs.netlify.app/openshift-rosa/latest/nodes/rosa-managing-worker-nodes#rosa-adding-node-labels_rosa-managing-worker-nodes