Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRVCOM-1501: Add Serverless 1.18.0 release notes #37574

Merged
merged 1 commit into from Oct 20, 2021
Merged

SRVCOM-1501: Add Serverless 1.18.0 release notes #37574

merged 1 commit into from Oct 20, 2021

Conversation

rh-max
Copy link
Contributor

@rh-max rh-max commented Oct 15, 2021 •
edited

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 15, 2021
@netlify
Copy link

netlify bot commented Oct 15, 2021 •
edited

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: f285ce5

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61703261d019740008d3dce1

😎 Browse the preview: https://deploy-preview-37574--osdocs.netlify.app/openshift-enterprise/latest/serverless/serverless-release-notes

@rh-max rh-max changed the title Add Serverless 1.18.0 release notes SRVCOM-1501: Add Serverless 1.18.0 release notes Oct 15, 2021
nak3
nak3 reviewed Oct 15, 2021
View reviewed changes
Copy link
Contributor

@nak3 nak3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default service type for Kourier will be changed in 1.19 not 1.18. (It is same with defaultExternalScheme.)
I'm sorry I forgot to update SRVKS-803.

modules/serverless-rn-1-18-0.adoc Outdated Show resolved Hide resolved
modules/serverless-rn-1-18-0.adoc Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 18, 2021
@nak3
Copy link
Contributor

nak3 commented Oct 18, 2021

/lgtm

LGTM for serving part. Thank you!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2021
mgencur
mgencur reviewed Oct 19, 2021
View reviewed changes
Copy link
Contributor

@mgencur mgencur left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! A couple of comments. Otherwise it looks good to me.

modules/serverless-rn-1-18-0.adoc Outdated Show resolved Hide resolved
modules/serverless-rn-1-18-0.adoc Outdated Show resolved Hide resolved
modules/serverless-rn-1-18-0.adoc Outdated Show resolved Hide resolved
cardil
cardil suggested changes Oct 19, 2021
View reviewed changes
modules/serverless-rn-1-18-0.adoc Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2021
EricPonvelle
EricPonvelle reviewed Oct 20, 2021
View reviewed changes
Copy link
Contributor

@EricPonvelle EricPonvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Small fix

modules/serverless-rn-1-18-0.adoc Outdated Show resolved Hide resolved
@EricPonvelle EricPonvelle added this to the Next Release milestone Oct 20, 2021
@rh-max
Add Serverless 1.18.0 release notes
f285ce5 
Add a fixed issue

%s/custom resource definition (CRD)/custom resource (CR)/

Fix Knative Kafka version

Add link to a Knowledgebase article

Co-authored-by: Chris Suszynski <krzysztof.suszynski@gmail.com>

s/Knowledge article/Knowledgebase article/

Add a new feature
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2021
@EricPonvelle EricPonvelle merged commit cc1bbfc into openshift:main Oct 20, 2021
@EricPonvelle
Copy link
Contributor

/cherry-pick enterprise-4.6

@EricPonvelle
Copy link
Contributor

/cherry-pick enterprise-4.7

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 20, 2021
Merged
@openshift-cherrypick-robot
Copy link

@EricPonvelle: new pull request created: #37789

In response to this:

/cherry-pick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 20, 2021
Merged
@openshift-cherrypick-robot
Copy link

@EricPonvelle: new pull request created: #37790

In response to this:

/cherry-pick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@EricPonvelle
Copy link
Contributor

/cherry-pick enterprise-4.8

@EricPonvelle
Copy link
Contributor

/cherry-pick enterprise-4.9

@EricPonvelle
Copy link
Contributor

/cherry-pick enterprise-4.10

@openshift-cherrypick-robot
Copy link

@EricPonvelle: #37574 failed to apply on top of branch "enterprise-4.8":

Applying: Add Serverless 1.18.0 release notes
Using index info to reconstruct a base tree...
A	modules/serverless-rn-1-14-0.adoc
A	modules/serverless-rn-1-15-0.adoc
M	serverless/serverless-release-notes.adoc
Falling back to patching base and 3-way merge...
Auto-merging serverless/serverless-release-notes.adoc
CONFLICT (modify/delete): modules/serverless-rn-1-15-0.adoc deleted in HEAD and modified in Add Serverless 1.18.0 release notes. Version Add Serverless 1.18.0 release notes of modules/serverless-rn-1-15-0.adoc left in tree.
CONFLICT (modify/delete): modules/serverless-rn-1-14-0.adoc deleted in HEAD and modified in Add Serverless 1.18.0 release notes. Version Add Serverless 1.18.0 release notes of modules/serverless-rn-1-14-0.adoc left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add Serverless 1.18.0 release notes
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@EricPonvelle: #37574 failed to apply on top of branch "enterprise-4.9":

Applying: Add Serverless 1.18.0 release notes
Using index info to reconstruct a base tree...
A	modules/serverless-rn-1-14-0.adoc
A	modules/serverless-rn-1-15-0.adoc
M	serverless/serverless-release-notes.adoc
Falling back to patching base and 3-way merge...
Auto-merging serverless/serverless-release-notes.adoc
CONFLICT (modify/delete): modules/serverless-rn-1-15-0.adoc deleted in HEAD and modified in Add Serverless 1.18.0 release notes. Version Add Serverless 1.18.0 release notes of modules/serverless-rn-1-15-0.adoc left in tree.
CONFLICT (modify/delete): modules/serverless-rn-1-14-0.adoc deleted in HEAD and modified in Add Serverless 1.18.0 release notes. Version Add Serverless 1.18.0 release notes of modules/serverless-rn-1-14-0.adoc left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add Serverless 1.18.0 release notes
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@EricPonvelle: #37574 failed to apply on top of branch "enterprise-4.10":

Applying: Add Serverless 1.18.0 release notes
Using index info to reconstruct a base tree...
A	modules/serverless-rn-1-14-0.adoc
A	modules/serverless-rn-1-15-0.adoc
M	serverless/serverless-release-notes.adoc
Falling back to patching base and 3-way merge...
Auto-merging serverless/serverless-release-notes.adoc
CONFLICT (modify/delete): modules/serverless-rn-1-15-0.adoc deleted in HEAD and modified in Add Serverless 1.18.0 release notes. Version Add Serverless 1.18.0 release notes of modules/serverless-rn-1-15-0.adoc left in tree.
CONFLICT (modify/delete): modules/serverless-rn-1-14-0.adoc deleted in HEAD and modified in Add Serverless 1.18.0 release notes. Version Add Serverless 1.18.0 release notes of modules/serverless-rn-1-14-0.adoc left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add Serverless 1.18.0 release notes
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgencur mgencur mgencur left review comments

@markusthoemmes markusthoemmes markusthoemmes left review comments

@nak3 nak3 nak3 left review comments

@mvinkler mvinkler mvinkler left review comments

@EricPonvelle EricPonvelle EricPonvelle left review comments

@abrennan89 abrennan89 abrennan89 left review comments

@cardil cardil cardil requested changes

Assignees

@nak3 nak3

@EricPonvelle EricPonvelle

Labels
branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 branch/enterprise-4.9 branch/enterprise-4.10 lgtm Indicates that a PR is ready to be merged. peer-review-needed Signifies that the peer review team needs to review this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@rh-max @nak3 @EricPonvelle @openshift-cherrypick-robot @mgencur @cardil @markusthoemmes @mvinkler @abrennan89