-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTA-472: Reorganizing upgrade section #37996
Conversation
fa028c7
to
243fcbf
Compare
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: 065d7b4ca6114f6aa6cd0c231afbfea9626ffce9 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61784d429d426a0007846667 😎 Browse the preview: https://deploy-preview-37996--osdocs.netlify.app |
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: 243fcbfe80b5704eed18bcd1a17c4a402dbd8f42 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61784ec5de9a6b00070f0b74 😎 Browse the preview: https://deploy-preview-37996--osdocs.netlify.app |
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: bb16d53 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6181fd184e47bc000849ef1b 😎 Browse the preview: https://deploy-preview-37996--osdocs.netlify.app |
6965f75
to
305a9d9
Compare
@LalatenduMohanty Ready for you to approve. I did want to ask about the fact that we did remove "between" version upgrade. My understanding is that the steps to do "between" and "within" versions are the same. So, should we drop the "within" from web console and CLI? If so, should we add a paragraph to let our customers know that no matter how they want to upgrade, they can use the steps? |
* `candidate-{product-version}` | ||
* `fast-{product-version}` | ||
* `stable-{product-version}` | ||
* `eus-4.6` (only available when running 4.6) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sagidlow I made a few updates to the understanding-upgrade-channels.adoc
module regarding EUS channels in #37939. I don't think that affects this reorg much other than this eus channel bullet. This has been updated in the module to read
* `eus-4.y` (only when running an even-numbered 4.y cluster release)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codyhoag thank you for letting me know. :)
@@ -1,5 +1,5 @@ | |||
[id="updating-cluster-between-minor"] | |||
= Updating a cluster between minor versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are changing the title of the document but the not changing the file name. IMO you should change the file name as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LalatenduMohanty Updated. :)
_topic_map.yml
Outdated
File: updating-cluster | ||
- Name: Updating a cluster within a minor version by using the CLI | ||
# - Name: Updating a cluster within a minor version from the web console | ||
# File: updating-cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are are not deleting the files, just hiding the old topic name. Are you planing to delete in future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LalatenduMohanty Will delete in the future. I was having linking issues and wanted to make sure that it would build without any errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LalatenduMohanty Deleted.
c5fc79c
to
078e9c7
Compare
@sagidlow: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@LalatenduMohanty could you please provide an ACK? |
@sagidlow I came here to review the PR, looks like the PR is closed now? |
Applies to 4.6+
JIRA Link: https://issues.redhat.com/browse/OTA-472
QE ack received on original PR (#36015). SME ack needed.
Preview Link: Understanding upgrade channels and releases
The remaining sections have been updated to remove the redundancy.