Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHDEVDOCS-3329 - Release Notes for OpenShift Logging 5.3 #38137

Merged
merged 1 commit into from Nov 17, 2021
Merged

RHDEVDOCS-3329 - Release Notes for OpenShift Logging 5.3 #38137

merged 1 commit into from Nov 17, 2021
+65 −14

Conversation

libander
Copy link
Contributor

@libander libander commented Oct 28, 2021 •
edited

@openshift-ci openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 28, 2021
@netlify
Copy link

netlify bot commented Oct 28, 2021 •
edited

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 58fa259

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/619565252183a20008a08c43

😎 Browse the preview: https://deploy-preview-38137--osdocs.netlify.app/openshift-enterprise/latest/logging/cluster-logging-release-notes

@anpingli
Copy link

anpingli commented Nov 1, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2021
@libander libander changed the title RHDEVDOCS-3350 RHDEVDOCS-3329 Nov 2, 2021
@libander libander changed the title RHDEVDOCS-3329 RHDEVDOCS-3329 - Release Notes for OpenShift Logging 5.3 Nov 10, 2021
@openshift-ci
Copy link

openshift-ci bot commented Nov 11, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2021
@libander libander changed the base branch from main to enterprise-4.9 November 15, 2021 21:17
@libander libander changed the base branch from enterprise-4.9 to main November 15, 2021 21:17
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 15, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2021
@libander libander force-pushed the RHDEVDOCS-3350 branch 2 times, most recently from adeb72b to 0fd7709 Compare November 16, 2021 22:29
@abrennan89 abrennan89 added branch/enterprise-4.9 branch/enterprise-4.10 peer-review-done Signifies that the peer review team has reviewed this PR labels Nov 17, 2021
@abrennan89 abrennan89 added this to the Next Release milestone Nov 17, 2021
@libander libander closed this Nov 17, 2021
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 17, 2021
@libander
Copy link
Contributor Author

.

@libander libander reopened this Nov 17, 2021
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 17, 2021
@abrennan89 abrennan89 merged commit 05718d7 into openshift:main Nov 17, 2021
@abrennan89
Copy link
Contributor

/cherrypick enterprise-4.9

@abrennan89
Copy link
Contributor

/cherrypick enterprise-4.10

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 17, 2021
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #38882

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 17, 2021
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #38883

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alanconway
alanconway reviewed Nov 18, 2021
View reviewed changes
Copy link

@alanconway alanconway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggested clarification, otherwise LGTM.

logging/cluster-logging-release-notes.adoc

[id="openshift-logging-5-3-0-new-features-and-enhancements"]
=== New features and enhancements
* With this update, authorization requirements for Log Forwarding have been relaxed. Outputs may now be configured with SASL, username/password, or TLS.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Relaxed" seems weird to me, we are offering more options. Suggestion:

Log forwarding outputs can now be configured with more TLS options: server-only or mutual authentication, using system default or custom certificates. SASL and username/password authentication are also available for some output types.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, but this one is already merged, so the change would need to be in a follow up PR 🙂

@libander libander mentioned this pull request Apr 25, 2022
Closed
@libander libander deleted the RHDEVDOCS-3350 branch May 2, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@periklis periklis periklis left review comments

@jcantrill jcantrill jcantrill left review comments

@alanconway alanconway alanconway left review comments

@abrennan89 abrennan89 abrennan89 left review comments

@jc-berger jc-berger jc-berger left review comments

@bburt-rh bburt-rh bburt-rh left review comments

@anpingli anpingli Awaiting requested review from anpingli

Assignees

@anpingli anpingli

Labels
branch/enterprise-4.9 branch/enterprise-4.10 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@libander @anpingli @abrennan89 @openshift-cherrypick-robot @periklis @jcantrill @alanconway @jc-berger @bburt-rh