Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRVKS-573: Updating autoscaling docs #38284

Merged
merged 1 commit into from
Nov 15, 2021
Merged

SRVKS-573: Updating autoscaling docs #38284

merged 1 commit into from
Nov 15, 2021

Conversation

abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Nov 1, 2021 •
edited

Jira: https://issues.redhat.com/browse/SRVKS-573 (related groundwork; there will be more PRs to add the ODC content and close this issue)

Applies for OCP 4.6+

Direct preview link: https://deploy-preview-38284--osdocs.netlify.app/openshift-enterprise/latest/serverless/autoscaling/serverless-autoscaling.html

@abrennan89 abrennan89 added this to the Next Release milestone Nov 1, 2021
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 1, 2021
@netlify
Copy link

netlify bot commented Nov 1, 2021 •
edited

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 510b974

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/619282def97b5e0008a5a224

😎 Browse the preview: https://deploy-preview-38284--osdocs.netlify.app

@abrennan89 abrennan89 force-pushed the SRVKS-573 branch 6 times, most recently from a9c85ee to 4c80105 Compare November 9, 2021 13:53
@abrennan89 abrennan89 changed the title [WIP] SRVKS-573: Updating autoscaling docs SRVKS-573: Updating autoscaling docs Nov 9, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 9, 2021
markusthoemmes
markusthoemmes reviewed Nov 10, 2021
View reviewed changes
Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG modulo one comment

@jrangelramos
Copy link
Contributor

LGTM
QE Approved

@bmcelvee bmcelvee added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Nov 11, 2021
@bmcelvee
Copy link
Contributor

Just a couple of questions and suggestions. Otherwise, LGTM!

Also, apologies for starting a review. I just meant to leave comments. 🤦‍♀️

@bmcelvee bmcelvee added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Nov 11, 2021
@abrennan89 abrennan89 changed the title SRVKS-573: Updating autoscaling docs [WIP] SRVKS-573: Updating autoscaling docs Nov 13, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2021
@abrennan89
Copy link
Contributor Author

Thanks for the comments @bmcelvee - decided to rework some of the docs because I think I can improve them a bit.
I'll send them for another peer review once updated. Thanks!

@abrennan89 abrennan89 changed the title [WIP] SRVKS-573: Updating autoscaling docs SRVKS-573: Updating autoscaling docs Nov 15, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 15, 2021
@bmcelvee
Copy link
Contributor

LGTM!

@abrennan89 abrennan89 merged commit 58fa259 into openshift:main Nov 15, 2021
@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.6

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.7

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.8

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.9

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.10

@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #38770

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Nov 15, 2021
Merged
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #38771

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #38772

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Nov 15, 2021
Merged
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #38773

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 15, 2021
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #38774

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89 abrennan89 deleted the SRVKS-573 branch December 17, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusthoemmes markusthoemmes markusthoemmes left review comments

@bmcelvee bmcelvee bmcelvee left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 branch/enterprise-4.9 branch/enterprise-4.10 peer-review-done Signifies that the peer review team has reviewed this PR serverless Label for all Serverless PRs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@abrennan89 @jrangelramos @bmcelvee @openshift-cherrypick-robot @markusthoemmes