Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHDEVDOCS-3389 Document Grafana removal from Monitoring stack #38687

Conversation

bburt-rh
Copy link
Contributor

@bburt-rh bburt-rh commented Nov 12, 2021

This PR removes from the documentation all references to the cluster monitoring Grafana dashboard component, which has been removed from the Monitoring stack and is no longer installed as part of OCP.

NOTE: The Grafana references in the Observe > Accessing third-party UIs section of the OCP documentation will be removed as part of a different PR: #38652

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 12, 2021
@netlify
Copy link

netlify bot commented Nov 12, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: c397e55

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61a50c21c3bbc6000940167d

😎 Browse the preview: https://deploy-preview-38687--osdocs.netlify.app

@lihongyan1
Copy link

Before merge the PR, we should make sure the 'Grafana removal' epic is completed
https://issues.redhat.com/browse/MON-1591

@@ -5,11 +5,11 @@ include::modules/common-attributes.adoc[]

toc::[]

{product-title} exposes metrics that the Cluster Monitoring Operator collects and stores in the Prometheus-based monitoring stack. As an administrator, you can view system resources, containers and components metrics in one dashboard interface, Grafana.
{product-title} exposes metrics that the Cluster Monitoring Operator collects and stores in the Prometheus-based monitoring stack. As an administrator, you can view system resources, containers and components metrics in the {product-title} web console in *Monitoring* > *Dashboards*.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be in Observe > Dashboards.

Copy link

@juzhao juzhao Nov 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juzhao
Copy link

juzhao commented Nov 19, 2021

FYI, https://deploy-preview-38687--osdocs.netlify.app/openshift-enterprise/latest/monitoring/understanding-the-monitoring-stack.html
the monitoring structure diagram has Grafana, it is better to remove it

@@ -147,7 +147,7 @@ image::quick-start-icon.png[quick start icon element in the web console]

- Kubernetes health probes and integration with Spring Actuator

- Metrics: Prometheus, Grafana, and integration with Spring Cloud Sleuth
- Metrics: Prometheus and integration with Spring Cloud Sleuth
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to remove, not related to cluster monitoring Grafana

@juzhao
Copy link

juzhao commented Nov 19, 2021

https://deploy-preview-38687--osdocs.netlify.app/openshift-enterprise/latest/post_installation_configuration/network-configuration.html
remove <apps_FIP> grafana-openshift-monitoring.apps.<cluster name>.<base domain>

@bburt-rh bburt-rh force-pushed the RHDEVDOCS-3389-document-grafana-removal branch from 9db166a to 9599d0c Compare November 29, 2021 16:44
@bburt-rh bburt-rh force-pushed the RHDEVDOCS-3389-document-grafana-removal branch from 9599d0c to c397e55 Compare November 29, 2021 17:21
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 27, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 27, 2022

@bburt-rh: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2022
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 29, 2022
@juzhao
Copy link

juzhao commented Mar 30, 2022

For modules/configuring-cluster-monitoring.adoc
I think we should fix https://bugzilla.redhat.com/show_bug.cgi?id=2060699 first

@bburt-rh bburt-rh closed this Mar 30, 2022
@bburt-rh
Copy link
Contributor Author

@juzhao I will see if we can get https://bugzilla.redhat.com/show_bug.cgi?id=2060699 for the next release

@bburt-rh
Copy link
Contributor Author

Closing because I opened a different PR for this

@bburt-rh bburt-rh deleted the RHDEVDOCS-3389-document-grafana-removal branch June 6, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants