Managing images: reference and insecure import policies #3890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ahardin-rh could you please take a look? |
ahardin-rh
reviewed
Mar 9, 2017
dev_guide/managing_images.adoc
Outdated
| be mirrored locally by the registry. As a result, they will be available in | ||
| shorter time next time they are needed. The flag also allows for pulling from | ||
| insecure registries without a need to supply `--insecure-registry` to the | ||
| Docker daemon if the image stream has an xref:#insecure-registries[insecure |
There was a problem hiding this comment.
You can drop the # within an xref if pointing to a section on the same page
ahardin-rh
reviewed
Mar 9, 2017
dev_guide/managing_images.adoc
Outdated
| shorter time next time they are needed. The flag also allows for pulling from | ||
| insecure registries without a need to supply `--insecure-registry` to the | ||
| Docker daemon if the image stream has an xref:#insecure-registries[insecure | ||
| annotation] or the tag has an xref:#insecure-tag-importpolicy[insecure import |
|
@miminar Is this targeted for 3.5? Overall, this looks good. I am going make some general style edits in a follow-up PR. Thanks! |
miminar
force-pushed
the
insecure-image-import
branch
from
345f42c
to
510a823
Compare
Documenting the latest changes to handling image stream tags annotated with above policies. Signed-off-by: Michal Minář <miminar@redhat.com>
miminar
force-pushed
the
insecure-image-import
branch
from
510a823
to
3bc4d4e
Compare
|
Thanks! Comments addressed. @ahardin-rh yes, 3.5. |
|
Thank you! |
|
[rev_history] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documenting the latest changes to handling image stream tags annotated
with above policies.