-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTA-472: Reorganizing and adding a channel management chapter #39613
Conversation
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: f42d0ff 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61b282f9d233010009d27978 😎 Browse the preview: https://deploy-preview-39613--osdocs.netlify.app/openshift-enterprise/latest/security/container_security/security-hosts-vms |
90681d7
to
ec79513
Compare
2739c11
to
0ef26dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! left just a couple questions
@@ -51,44 +29,46 @@ endif::[] | |||
for more build information. | |||
==== | |||
|
|||
[discrete] | |||
== fast-{product-version} channel | |||
[id="fast-version-channel_{context}"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call giving these all ids
installing/installing_bare_metal_ipi/ipi-install-installation-workflow.adoc
Outdated
Show resolved
Hide resolved
a8aa235
to
b879dc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cherrypick enterprise-4.10 |
@sagidlow: new pull request created: #39766 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Applies to 4.10+
JIRA Link: https://issues.redhat.com/browse/OTA-472
QE ack received on original PR (#36015). SME ack needed.
Preview: Understanding upgrade channels
The remaining sections have been updated to remove the redundancy.