Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHDEVDOCS-3570 Docs: Use sidecar pattern for Jenkins pod templates #39873

Merged
merged 1 commit into from Jan 7, 2022
Merged

RHDEVDOCS-3570 Docs: Use sidecar pattern for Jenkins pod templates #39873

merged 1 commit into from Jan 7, 2022

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Dec 14, 2021 •
edited

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 14, 2021
@rolfedh rolfedh mentioned this pull request Dec 14, 2021
Closed
@netlify
Copy link

netlify bot commented Dec 14, 2021 •
edited

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: df0b970

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61d5dec5b1a05e00087d0c8d

😎 Browse the preview: https://deploy-preview-39873--osdocs.netlify.app

gabemontero
gabemontero suggested changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@gabemontero gabemontero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a minor clarification/addition the text I provided to you previously @rolfedh

modules/images-other-jenkins-config-kubernetes.adoc Outdated Show resolved Hide resolved
gabemontero
gabemontero approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@gabemontero gabemontero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jan 4, 2022
@gabemontero
Copy link
Contributor

@prietyc123 @rolfedh @akram let's be sure that using both labels in the new examples provided work when @prietyc123 verifies both JNKS-257 and https://bugzilla.redhat.com/show_bug.cgi?id=2034839

@rolfedh rolfedh changed the title [WIP]RHDEVDOCS-3570 Docs: Use sidecar pattern for Jenkins pod templates RHDEVDOCS-3570 Docs: Use sidecar pattern for Jenkins pod templates Jan 5, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 5, 2022
@gabemontero
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2022
@gabemontero
Copy link
Contributor

Let's go ahead and merge this @rolfedh if you are ready ....any tweaks needed based on @prietyc123 's testing can come under new PRs under https://bugzilla.redhat.com/show_bug.cgi?id=2034839 or any new BZ's she opens.

@rolfedh
Copy link
Contributor Author

rolfedh commented Jan 7, 2022

Thanks, @gabemontero. @prietyc123 and @akram, if you both agree, please sign off on this PR with /lgtm and I'll get it merged.

@prietyc123
Copy link

lgtm

@Preeticp Preeticp added branch/enterprise-4.10 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs peer-review-done Signifies that the peer review team has reviewed this PR lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jan 7, 2022
@Preeticp Preeticp added this to the Next Release milestone Jan 7, 2022
@Preeticp Preeticp merged commit 0dabc8b into openshift:main Jan 7, 2022
@Preeticp
Copy link
Contributor

Preeticp commented Jan 7, 2022

/cherrypick enterprise-4.10

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 7, 2022
Merged
@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #40339

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero
Copy link
Contributor

@rolfedh - during are grooming today we discovered that one of the doc items we need for this story was declaring that the existing PodTemplates are deprecated (the non side car pod templates)

I don't think we did that in this PR.

We'll also want a deprecation item in the 4.10 release notes.

How should we go about tracking that additional work? Bugzilla ? Jira work item?

@adambkaplan FYI

@rolfedh
Copy link
Contributor Author

rolfedh commented Jan 14, 2022

@rolfedh - during are grooming today we discovered that one of the doc items we need for this story was declaring that the existing PodTemplates are deprecated (the non side car pod templates)

I don't think we did that in this PR.

We'll also want a deprecation item in the 4.10 release notes.

How should we go about tracking that additional work? Bugzilla ? Jira work item?

@adambkaplan FYI

Thanks for catching that, @gabemontero. I've created https://issues.redhat.com/browse/RHDEVDOCS-3644 to track that work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akram akram akram left review comments

@gabemontero gabemontero gabemontero approved these changes

@prietyc123 prietyc123 prietyc123 requested changes

Assignees

@gabemontero gabemontero

Labels
branch/enterprise-4.10 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rolfedh @gabemontero @prietyc123 @Preeticp @openshift-cherrypick-robot @akram