Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F5-router, "Idling applications" feature does not work #4068

Merged
merged 1 commit into from Apr 10, 2017

Conversation

pecameron
Copy link

OSE 3.5, 3.4, and 3.3

Made a NOTE that this is HAProxy only
(moved last to lines of file into note)

bug 143165
https://bugzilla.redhat.com/show_bug.cgi?id=1431658

@pecameron
Copy link
Author

@knobunc PTAL

@@ -16,6 +16,12 @@ toc::[]
As an {product-title} administrator, you can idle applications in order to
reduce the consumption of resources.

[NOTE]
====
This works when using the default HAProxy router. You will need to configure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erm... you can't configure the F5 to do this. It requires a code change, and we need to work out how to make it do it (or make it use the service IP... but it doesn't have access to the service network, so it's ugly).

How about "Automatic unidling by a router is currently only supported by the default HAProxy router"

But it really does belong at the bottom since that's the bit that mentions routes.

Should we add a caveat to the F5 section too? So that people are informed when they pick the F5?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@pecameron
Copy link
Author

@knobunc Anything else? PTAL

@pecameron
Copy link
Author

@knobunc PTAL

Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Should we also drop a note over in the F5 router information so that you are informed when setting up F5?

@pecameron
Copy link
Author

@knobunc You still have Changes requested set...

@pecameron
Copy link
Author

@knobunc Is this ready to merge?

@pecameron
Copy link
Author

@ahardin-rh Are you the docs person that will handle this?

@knobunc
Copy link
Contributor

knobunc commented Apr 7, 2017

@pecameron yes, it is ready to merge. But should we also add a note in the F5 section of the docs noting this limitation?

@ahardin-rh
Copy link
Contributor

LGTM!

@ahardin-rh ahardin-rh merged commit dc968f2 into openshift:master Apr 10, 2017
@ahardin-rh
Copy link
Contributor

[rev_history]
|xref:..admin_guide/idling_applications.adoc#admin-guide-idling-applications[Idling Applications]
|Noted that automatic unidling by a router is currently only supported by the default HAProxy router.
%

@vikram-redhat vikram-redhat modified the milestones: Next Release, Staging Apr 12, 2017
@pecameron pecameron deleted the bz1431658 branch April 12, 2017 15:19
@vikram-redhat vikram-redhat modified the milestones: Staging, Published - 04/12/2017 Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants