-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHDEVDOCS-3703 Pipelines 1.6.2 Release Notes #41326
RHDEVDOCS-3703 Pipelines 1.6.2 Release Notes #41326
Conversation
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: 9be9599 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/620a50a47592900008db3384 😎 Browse the preview: https://deploy-preview-41326--osdocs.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sounix000: Nice work! I have left some suggestions for the template usage and language/structure consistency. PTAL. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sounix000 Left a couple of suggestions. PTAL and address them. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sounix000 Small nitpick. LGTM :)
Good job! Thanks for addressing all my comments.
/lgtm |
@sounix000 Please address the nitpick and squash the commits before the merge request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
modules/op-release-notes-1-6.adoc
Outdated
=== Fixed issues | ||
|
||
* The Operator ensures that only one instance of each type of `TektonInstallerSet` exists after an upgrade. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikhil-thomas you mentioned today that we don't remove installer sets for cluster tasks, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are now 2 installersets for clusterTasks. 1 for managing "non-versioned clustertasks" (eg. name: buildah
) and the other for managing "versioned clustertasks" (eg. name: buildah-1-6
, name: buildah-1-7
etc) . The one managing versioned clustertask will not be deleted. there will be a suffix (-1-6-, -1-7- in the one which will not be deleted)
New changes are detected. LGTM label has been removed. |
revised based on engineering draft, and some rearrangement Sri's suggestion minor corrections nitpick added known issue minor modifications trying to fix head trying to fix head
Closing due to a rogue commit creeping in, probably during rebase. Nothing has worked, even hard reset of HEAD hasn't worked. New PR: #41822 |
enterprise-4.9
,enterprise-4.10