Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHDEVDOCS-3703 Pipelines 1.6.2 Release Notes #41326

Closed
wants to merge 3 commits into from
Closed

RHDEVDOCS-3703 Pipelines 1.6.2 Release Notes #41326

wants to merge 3 commits into from

Conversation

sounix000
Copy link
Contributor

@sounix000 sounix000 commented Feb 3, 2022

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 3, 2022
@netlify
Copy link

netlify bot commented Feb 3, 2022

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 9be9599

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/620a50a47592900008db3384

😎 Browse the preview: https://deploy-preview-41326--osdocs.netlify.app

Copy link
Member

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sounix000: Nice work! I have left some suggestions for the template usage and language/structure consistency. PTAL. Thanks!

modules/op-release-notes-1-6.adoc Outdated Show resolved Hide resolved
modules/op-release-notes-1-6.adoc Outdated Show resolved Hide resolved
modules/op-release-notes-1-6.adoc Outdated Show resolved Hide resolved
modules/op-release-notes-1-6.adoc Outdated Show resolved Hide resolved
modules/op-release-notes-1-6.adoc Outdated Show resolved Hide resolved
modules/op-release-notes-1-6.adoc Outdated Show resolved Hide resolved
Copy link
Member

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sounix000 Left a couple of suggestions. PTAL and address them. Thanks!

modules/op-release-notes-1-6.adoc Outdated Show resolved Hide resolved
modules/op-release-notes-1-6.adoc Outdated Show resolved Hide resolved
Copy link
Member

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sounix000 Small nitpick. LGTM :)
Good job! Thanks for addressing all my comments.

@Srivaralakshmi
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2022
@Srivaralakshmi
Copy link
Member

@sounix000 Please address the nitpick and squash the commits before the merge request.

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 7, 2022
Copy link

@ppitonak ppitonak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

=== Fixed issues

* The Operator ensures that only one instance of each type of `TektonInstallerSet` exists after an upgrade.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikhil-thomas you mentioned today that we don't remove installer sets for cluster tasks, correct?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are now 2 installersets for clusterTasks. 1 for managing "non-versioned clustertasks" (eg. name: buildah) and the other for managing "versioned clustertasks" (eg. name: buildah-1-6, name: buildah-1-7 etc) . The one managing versioned clustertask will not be deleted. there will be a suffix (-1-6-, -1-7- in the one which will not be deleted)

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 14, 2022

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 14, 2022
Souvik Sarkar added 2 commits February 14, 2022 16:31
revised based on engineering draft, and some rearrangement

Sri's suggestion

minor corrections

nitpick

added known issue

minor modifications

trying to fix head

trying to fix head
@sounix000
Copy link
Contributor Author

Closing due to a rogue commit creeping in, probably during rebase. Nothing has worked, even hard reset of HEAD hasn't worked.

New PR: #41822

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants