Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHDEVDOCS-3850 Add link to solution: How to use builds with Red Hat S… #43015

Merged
merged 1 commit into from
Mar 14, 2022
Merged

RHDEVDOCS-3850 Add link to solution: How to use builds with Red Hat S… #43015

merged 1 commit into from
Mar 14, 2022

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Mar 9, 2022 •
edited

Aligned team: Dev Tools

@openshift-ci openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 9, 2022
@netlify
Copy link

netlify bot commented Mar 9, 2022

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 94798c6f8d9b29c2fbd4eab2c0af0e0e4a64383f

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6228968a6ffa1b0008f79c72

😎 Browse the preview: https://deploy-preview-43015--osdocs.netlify.app

@netlify
Copy link

netlify bot commented Mar 9, 2022 •
edited

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 1a35b7e

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6228ac502f0e97000a7e6c62

😎 Browse the preview: https://deploy-preview-43015--osdocs.netlify.app

Srivaralakshmi
Srivaralakshmi requested changes Mar 9, 2022
View reviewed changes
Copy link
Member

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rolfedh Left a couple of suggestions. PTAL. Thanks!

cicd/builds/running-entitled-builds.adoc Show resolved Hide resolved
@rolfedh
RHDEVDOCS-3850 Add link to solution: How to use builds with Red Hat S…
1a35b7e 
…atellite subscriptions and which certificate to use
Srivaralakshmi
Srivaralakshmi approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Srivaralakshmi
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2022
@prietyc123
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 10, 2022
@bergerhoffer
Copy link
Contributor

The branch/enterprise-4.11 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.10. And any PR going into main must also target the latest version branch (enterprise-4.11).

If the update in your PR does NOT apply to version 4.11 onward, please retarget this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@Preeticp Preeticp merged commit 7e62af0 into openshift:main Mar 14, 2022
@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.10

@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.11

@Preeticp Preeticp added this to the Next Release milestone Mar 14, 2022
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 14, 2022
Merged
@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #43188

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 14, 2022
Merged
@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #43189

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bergerhoffer
Copy link
Contributor

@Preeticp @rolfedh this PR was labeled for 4.9 but not cherry-picked to enterprise-4.9. Just checking if it needed to be. Thanks!

@rolfedh
Copy link
Contributor Author

rolfedh commented Mar 15, 2022

@Preeticp @rolfedh this PR was labeled for 4.9 but not cherry-picked to enterprise-4.9. Just checking if it needed to be. Thanks!

Thanks for catching that, Andrea. That "4.9+" is an error. This is for "4.10+" only. This PR doesn't need to be cherry-picked to 4.9. I'll update the description now.

@Preeticp
Copy link
Contributor

Thanks Andrea and Rolfe!

@bergerhoffer
Copy link
Contributor

Thanks @rolfedh! I'll remove the enterprise-4.9 label as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Srivaralakshmi Srivaralakshmi Srivaralakshmi approved these changes

Assignees

@Srivaralakshmi Srivaralakshmi

Labels
branch/enterprise-4.10 branch/enterprise-4.11 lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rolfedh @Srivaralakshmi @prietyc123 @bergerhoffer @Preeticp @openshift-cherrypick-robot @abrennan89