-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MIG 1040 Document additional excluded resources #43248
MIG 1040 Document additional excluded resources #43248
Conversation
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: 7c7de0b 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/623329e3ac4285000820d9f7 😎 Browse the preview: https://deploy-preview-43248--osdocs.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QE approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember to squash your commits.
@@ -68,5 +58,5 @@ The output contains the excluded resources: | |||
---- | |||
- name: EXCLUDED_RESOURCES | |||
value: | |||
imagetags,templateinstances,clusterserviceversions,packagemanifests,subscriptions,servicebrokers,servicebindings,serviceclasses,serviceinstances,serviceplans,imagestreams,persistentvolumes,persistentvolumeclaims | |||
foo,bar,imagetags,templateinstances,clusterserviceversions,packagemanifests,subscriptions,servicebrokers,servicebindings,serviceclasses,serviceinstances,serviceplans,imagestreams,persistentvolumes,persistentvolumeclaims |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous fubar comment.
Is the list of values be indented like the lines above it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nalhadef
Corrections made, commits squashed. Thank you!
a5b8314
to
7c7de0b
Compare
/lgtm |
/cherrypick enterprise-4.9 |
/cherrypick enterprise-4.10 |
/cherrypick enterprise-4.11 |
@EricPonvelle: new pull request created: #43398 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@EricPonvelle: new pull request created: #43399 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@EricPonvelle: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.9 from head openshift-cherrypick-robot:cherry-pick-43248-to-enterprise-4.9: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-43248-to-enterprise-4.9."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@EricPonvelle: new pull request created: #43400 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@EricPonvelle: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.10 from head openshift-cherrypick-robot:cherry-pick-43248-to-enterprise-4.10: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-43248-to-enterprise-4.10."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@EricPonvelle: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.11 from head openshift-cherrypick-robot:cherry-pick-43248-to-enterprise-4.11: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-43248-to-enterprise-4.11."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
MIG 1040 Document additional excluded resources
https://issues.redhat.com/browse/MIG-1040
MTC 1.7
Preview: https://deploy-preview-43248--osdocs.netlify.app/openshift-enterprise/latest/migration_toolkit_for_containers/advanced-migration-options-mtc.html#migration-excluding-resources_advanced-migration-options-mtc