Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BZ2065025: AWS Instance - fix references to current type (M6i) #43558

Merged
merged 1 commit into from Apr 18, 2022
Merged

BZ2065025: AWS Instance - fix references to current type (M6i) #43558

merged 1 commit into from Apr 18, 2022

Conversation

mtulio
Copy link
Contributor

@mtulio mtulio commented Mar 21, 2022 •
edited

Review references to current instance types on AWS for 4.10.

References:

cc related teams: @staebler @patrickdillon @JoelSpeed @sdodson

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 21, 2022
@netlify
Copy link

netlify bot commented Mar 21, 2022 •
edited

✅ Deploy Preview for osdocs ready!

Name Link
🔨 Latest commit 456e795
🔍 Latest deploy log https://app.netlify.com/sites/osdocs/deploys/625569086689aa0008b7c4f8
😎 Deploy Preview https://deploy-preview-43558--osdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

mtulio
mtulio commented Mar 21, 2022
View reviewed changes
modules/installation-supported-aws-machine-types.adoc
@@ -130,11 +130,41 @@ The following Amazon Web Services (AWS) instance types are supported with {produ
|x
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After openshift/installer#5334 , the current list of bootstrap type is outdated. I believe we need to fix this list too. Let me know wdyt @patrickdillon

@mtulio mtulio mentioned this pull request Mar 21, 2022
Closed
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 24, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 24, 2022
@mtulio mtulio force-pushed the fix-bz2065025 branch 2 times, most recently from c6a4071 to 298af1e Compare March 24, 2022 15:17
tmalove
tmalove reviewed Mar 24, 2022
View reviewed changes
modules/aws-limits.adoc Outdated Show resolved Hide resolved
mtulio
mtulio commented Mar 24, 2022
View reviewed changes
Copy link
Contributor Author

@mtulio mtulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

team review

modules/aws-limits.adoc Outdated Show resolved Hide resolved
modules/installation-aws-limits.adoc Outdated Show resolved Hide resolved
@mtulio
Copy link
Contributor Author

mtulio commented Mar 24, 2022

@tmalove done

@ahardin-rh ahardin-rh added this to the Next Release milestone Mar 24, 2022
@ahardin-rh
Copy link
Contributor

@yunjiang29 Can you please provide QE review or point us to the correct contact? Thank you!

@mtulio mtulio force-pushed the fix-bz2065025 branch 2 times, most recently from 71a303b to 43cef14 Compare March 30, 2022 12:04
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 30, 2022
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 31, 2022
@yunjiang29
Copy link
Contributor

@mtulio lgtm, thanks for the updates.

@ahardin-rh ahardin-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Apr 18, 2022
@ahardin-rh ahardin-rh merged commit 94abf5d into openshift:main Apr 18, 2022
@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-4.10

@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-4.11

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 18, 2022
Merged
@openshift-cherrypick-robot
Copy link

@ahardin-rh: new pull request created: #44641

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 18, 2022
Merged
@openshift-cherrypick-robot
Copy link

@ahardin-rh: new pull request created: #44642

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtulio mtulio deleted the fix-bz2065025 branch April 18, 2022 14:17
@mtulio mtulio mentioned this pull request May 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunjiang29 yunjiang29 yunjiang29 left review comments

@tmalove tmalove tmalove left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.10 branch/enterprise-4.11 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mtulio @ahardin-rh @yunjiang29 @openshift-cherrypick-robot @tmalove