Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHDEVDOCS-3827 - fix incorrect indent in tls config sample #43845

Conversation

bburt-rh
Copy link
Contributor

@bburt-rh bburt-rh commented Mar 25, 2022

Summary: This PR fixes an issue with incorrect indentation in the tlsConfig section of sample code in the "Configuring remote write storage" topic. It also renames the file to be consistent with OpenShift docs file naming standards and updates the assembly file with the changed file name.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 25, 2022
@netlify
Copy link

netlify bot commented Mar 25, 2022

Deploy Preview for osdocs ready!

Name Link
🔨 Latest commit bc4a9a5
🔍 Latest deploy log https://app.netlify.com/sites/osdocs/deploys/623dfb8f28ae6100083c4571
😎 Deploy Preview https://deploy-preview-43845--osdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2022
@juzhao
Copy link

juzhao commented Mar 30, 2022

/lgtm

@jan--f
Copy link
Contributor

jan--f commented Mar 30, 2022

/lgtm

@Preeticp Preeticp added dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs branch/enterprise-4.9 branch/enterprise-4.10 branch/enterprise-4.11 labels Mar 30, 2022
@Preeticp Preeticp merged commit 64595b5 into openshift:main Mar 30, 2022
@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.9

@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.10

@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.11

@openshift-cherrypick-robot

@Preeticp: new pull request created: #43961

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@Preeticp: new pull request created: #43962

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@Preeticp: new pull request created: #43963

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bburt-rh bburt-rh deleted the RHDEVDOCS-3827-fix-incorrect-indent-in-tls-config-sample branch June 6, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.9 branch/enterprise-4.10 branch/enterprise-4.11 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants