Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHDEVDOCS-3878 - 5.4 Release Notes #44624

Merged
merged 1 commit into from Apr 27, 2022
Merged

RHDEVDOCS-3878 - 5.4 Release Notes #44624

merged 1 commit into from Apr 27, 2022

Conversation

libander
Copy link
Contributor

@libander libander commented Apr 15, 2022 •
edited

@openshift-ci openshift-ci bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 15, 2022
@netlify
Copy link

netlify bot commented Apr 15, 2022 •
edited

✅ Deploy Preview for osdocs ready!

Name Link
🔨 Latest commit 14b2cd1
🔍 Latest deploy log https://app.netlify.com/sites/osdocs/deploys/6269a4d1b3a36100085405e4
😎 Deploy Preview https://deploy-preview-44624--osdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@libander libander changed the title RHDEVDOCS-3878 - DRAFT RHDEVDOCS-3878 - 5.4 Release Notes Apr 15, 2022
@libander

This comment was marked as outdated.

Sign in to view
@jcantrill
Copy link

@periklis @xperimental please review

@jcantrill
Copy link

@libander this LGTM other then seems sparse on content for features. Is this an initial PR with more to come?

Srivaralakshmi
Srivaralakshmi requested changes Apr 18, 2022
View reviewed changes
Copy link
Member

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@libander Nice work! Left some suggestions. PTAL. Thanks!

modules/cluster-logging-release-notes-5.4.0.adoc Outdated Show resolved Hide resolved
modules/cluster-logging-release-notes-5.4.0.adoc Outdated Show resolved Hide resolved
modules/cluster-logging-release-notes-5.4.0.adoc Outdated Show resolved Hide resolved
modules/cluster-logging-release-notes-5.4.0.adoc Outdated Show resolved Hide resolved
modules/cluster-logging-release-notes-5.4.0.adoc Outdated Show resolved Hide resolved
modules/cluster-logging-release-notes-5.4.0.adoc Outdated Show resolved Hide resolved
modules/cluster-logging-release-notes-5.4.0.adoc Outdated Show resolved Hide resolved
modules/cluster-logging-release-notes-5.4.0.adoc Outdated Show resolved Hide resolved
modules/cluster-logging-release-notes-5.4.z.adoc Outdated Show resolved Hide resolved
modules/cluster-logging-release-notes-5.4.0.adoc Outdated Show resolved Hide resolved
@libander

This comment was marked as outdated.

Sign in to view
@anpingli
Copy link

@libander “Logging subsystem for Red Hat OpenShift 5.4"! shall we rename it to Logging subsystem 5.4 for Red Hat OpenShift

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 20, 2022
@libander libander force-pushed the RHDEVDOCS-3878 branch 2 times, most recently from d926eec to 5132954 Compare April 25, 2022 04:02
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 25, 2022
vimalk78
vimalk78 reviewed Apr 25, 2022
View reviewed changes
modules/cluster-logging-vector-tech-preview.adoc Outdated Show resolved Hide resolved
modules/cluster-logging-vector-tech-preview.adoc Outdated Show resolved Hide resolved
modules/cluster-logging-vector-tech-preview.adoc Outdated Show resolved Hide resolved
modules/cluster-logging-vector-tech-preview.adoc Outdated Show resolved Hide resolved
@libander libander force-pushed the RHDEVDOCS-3878 branch 2 times, most recently from add1728 to 6827975 Compare April 25, 2022 05:50
@libander
Copy link
Contributor Author

@libander “Logging subsystem for Red Hat OpenShift 5.4"! shall we rename it to Logging subsystem 5.4 for Red Hat OpenShift

I don't think we're allowed to. The Official name is logging subsystem for Red Hat OpenShift, I don't think we can throw in modifiers.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 27, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 27, 2022
@kabirbhartiRH
Copy link

/lgtm
Detailed steps for Loki to be followed up as a part of https://issues.redhat.com/browse/RHDEVDOCS-3138

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2022
@libander libander closed this Apr 27, 2022
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 27, 2022
@libander libander reopened this Apr 27, 2022
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 27, 2022
jcantrill
jcantrill reviewed Apr 27, 2022
View reviewed changes
Copy link

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2022
@JStickler JStickler added branch/enterprise-4.10 branch/enterprise-4.11 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs labels Apr 27, 2022
@JStickler JStickler merged commit 93f73d7 into openshift:main Apr 27, 2022
@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.10

@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.11

@openshift-cherrypick-robot
Copy link

@JStickler: #44624 failed to apply on top of branch "enterprise-4.10":

Applying: RHDEVDOCS-3878 - 5.4 RN w/ edits - peer review & QE/SME changes - rebased v2
.git/rebase-apply/patch:988: trailing whitespace.
* Before this update, the OpenShift Logging dashboard showed the number of shards 'x' times bigger than actual value when Elasticsearch has 'x' nodes. This was because it was printing all primary shards for each ES pod and processing sum on it, while the output is always for the whole ES cluster. With this update, the calculation has been corrected.	(link:https://issues.redhat.com/browse/LOG-2156[LOG-2156])	
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	logging/cluster-logging-release-notes.adoc
A	modules/cluster-logging-release-notes-5.0.7.adoc
M	modules/cluster-logging-release-notes-5.1.0.adoc
M	modules/cluster-logging-release-notes-5.3.z.adoc
Falling back to patching base and 3-way merge...
Removing modules/cluster-logging-supported-versions.adoc
CONFLICT (modify/delete): modules/cluster-logging-release-notes-5.3.z.adoc deleted in RHDEVDOCS-3878 - 5.4 RN w/ edits - peer review & QE/SME changes - rebased v2 and modified in HEAD. Version HEAD of modules/cluster-logging-release-notes-5.3.z.adoc left in tree.
Removing modules/cluster-logging-release-notes-5.2.z.adoc
CONFLICT (modify/delete): modules/cluster-logging-release-notes-5.1.0.adoc deleted in RHDEVDOCS-3878 - 5.4 RN w/ edits - peer review & QE/SME changes - rebased v2 and modified in HEAD. Version HEAD of modules/cluster-logging-release-notes-5.1.0.adoc left in tree.
Auto-merging logging/cluster-logging-release-notes.adoc
CONFLICT (content): Merge conflict in logging/cluster-logging-release-notes.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 RHDEVDOCS-3878 - 5.4 RN w/ edits - peer review & QE/SME changes - rebased v2
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@JStickler: #44624 failed to apply on top of branch "enterprise-4.11":

Applying: RHDEVDOCS-3878 - 5.4 RN w/ edits - peer review & QE/SME changes - rebased v2
.git/rebase-apply/patch:988: trailing whitespace.
* Before this update, the OpenShift Logging dashboard showed the number of shards 'x' times bigger than actual value when Elasticsearch has 'x' nodes. This was because it was printing all primary shards for each ES pod and processing sum on it, while the output is always for the whole ES cluster. With this update, the calculation has been corrected.	(link:https://issues.redhat.com/browse/LOG-2156[LOG-2156])	
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	logging/cluster-logging-release-notes.adoc
A	modules/cluster-logging-release-notes-5.0.7.adoc
M	modules/cluster-logging-release-notes-5.1.0.adoc
Falling back to patching base and 3-way merge...
Removing modules/cluster-logging-supported-versions.adoc
Removing modules/cluster-logging-release-notes-5.3.z.adoc
Removing modules/cluster-logging-release-notes-5.2.z.adoc
CONFLICT (modify/delete): modules/cluster-logging-release-notes-5.1.0.adoc deleted in RHDEVDOCS-3878 - 5.4 RN w/ edits - peer review & QE/SME changes - rebased v2 and modified in HEAD. Version HEAD of modules/cluster-logging-release-notes-5.1.0.adoc left in tree.
Auto-merging logging/cluster-logging-release-notes.adoc
CONFLICT (content): Merge conflict in logging/cluster-logging-release-notes.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 RHDEVDOCS-3878 - 5.4 RN w/ edits - peer review & QE/SME changes - rebased v2
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Apr 27, 2022
Merged
Merged
@libander libander deleted the RHDEVDOCS-3878 branch May 2, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xperimental xperimental xperimental left review comments

@periklis periklis periklis requested changes

@jcantrill jcantrill jcantrill requested changes

@anpingli anpingli anpingli left review comments

@kabirbhartiRH kabirbhartiRH kabirbhartiRH left review comments

@rolfedh rolfedh rolfedh approved these changes

@Srivaralakshmi Srivaralakshmi Awaiting requested review from Srivaralakshmi

@IshwarKanse IshwarKanse Awaiting requested review from IshwarKanse

@vimalk78 vimalk78 Awaiting requested review from vimalk78

Assignees

@vimalk78 vimalk78

@jcantrill jcantrill

@kabirbhartiRH kabirbhartiRH

Labels
branch/enterprise-4.10 branch/enterprise-4.11 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet