Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NE-709, update router default to random balancing algorithm #44889

Merged
merged 1 commit into from May 19, 2022
Merged

NE-709, update router default to random balancing algorithm #44889

merged 1 commit into from May 19, 2022

Conversation

ahardin-rh
Copy link
Contributor

@ahardin-rh ahardin-rh commented Apr 22, 2022 •
edited

@ahardin-rh ahardin-rh added this to the Future Release milestone Apr 22, 2022
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 22, 2022
@netlify
Copy link

netlify bot commented Apr 22, 2022

✅ Deploy Preview for osdocs ready!

Name Link
🔨 Latest commit 6b78d77
🔍 Latest deploy log https://app.netlify.com/sites/osdocs/deploys/6262f965be51c20008342542
😎 Deploy Preview https://deploy-preview-44889--osdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ahardin-rh ahardin-rh self-assigned this Apr 22, 2022
@ahardin-rh
Copy link
Contributor Author

@gcs278 @quarterpin Please review when you have a moment. Thank you!

@gcs278
Copy link

gcs278 commented Apr 26, 2022

@ahardin-rh looks good to me. Quick and easy fix. I suppose we will hang on to this PR until the code is submitted to change to random?

@ahardin-rh
Copy link
Contributor Author

@gcs278 Thanks! Yes, we will hold off on merging until the code is merged, but I will get all of the appropriate reviews in place in the meantime. 🚀

@quarterpin
Copy link

/lgtm
Thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2022
@bergerhoffer bergerhoffer added the peer-review-done Signifies that the peer review team has reviewed this PR label May 2, 2022
bergerhoffer
bergerhoffer reviewed May 2, 2022
View reviewed changes
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ahardin-rh ahardin-rh added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2022
@ahardin-rh
Copy link
Contributor Author

Hold - waiting on code to merge

@ahardin-rh ahardin-rh removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2022
@ahardin-rh
Copy link
Contributor Author

Code is now merged: openshift/cluster-ingress-operator#727

@ahardin-rh ahardin-rh merged commit 9e37f2a into openshift:main May 19, 2022
@ahardin-rh
Copy link
Contributor Author

/cherrypick enterprise-4.11

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 19, 2022
Merged
@openshift-cherrypick-robot
Copy link

@ahardin-rh: new pull request created: #45871

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahardin-rh ahardin-rh mentioned this pull request May 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergerhoffer bergerhoffer bergerhoffer left review comments

@gcs278 gcs278 Awaiting requested review from gcs278

@quarterpin quarterpin Awaiting requested review from quarterpin

Assignees

@ahardin-rh ahardin-rh

@quarterpin quarterpin

Labels
branch/enterprise-4.11 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.11 GA
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ahardin-rh @gcs278 @quarterpin @openshift-cherrypick-robot @bergerhoffer @kalexand-rh