New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSSMDOC-550: Document new WasmPlugin API. #45111
Conversation
✅ Deploy Preview for osdocs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
b54558d
to
2d55335
Compare
@dgn, please review since you are the resident expert on WASM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm except for the container image format
29d8921
to
853bf9b
Compare
@dgn I revised the WasmPlugin container format topic. I could use a second review for that topic please. |
@skondkar Can you provide more details on the error on 2.2? Feel free to create a ticket in Jira with the details/step to reproduce and tag me there. |
About error on 2.2, the steps followed:
apiVersion: maistra.io/v1
Error from server: error when creating "extension.yaml": admission webhook "rev.validation.istio.io" denied the request: unrecognized type ServiceMeshExtension
|
Please, create a Jira and include all details in there (OCP version, SMCP yaml, etc) |
@jwendell thanks, |
LGTM. Verified that while creating ServiceMeshExtension, it shows below warning: |
Received ack via Slack that this PR is good to go and can move to peer review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Mostly some minor ISG nits and API object references. I realize that a lot of what GH perceives as file changes in content are actually from modularization, so if any of this is out of scope with your changes, I apologize
Added note that WebAssembly extensions not supported on IBM Power and Z systems at request of IBM technical writers. |
Merging now to get this into main so that Eng and 3scale team can work on documenting the next steps. |
/cherry-pick enterprise-4.6 |
/cherry-pick enterprise-4.7 |
/cherry-pick enterprise-4.8 |
/cherry-pick enterprise-4.9 |
/cherry-pick enterprise-4.10 |
/cherry-pick enterprise-4.11 |
@JStickler: new pull request created: #47251 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@JStickler: new pull request created: #47252 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@JStickler: new pull request created: #47253 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@JStickler: new pull request created: #47254 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@JStickler: new pull request created: #47255 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick enterprise-4.8 |
@JStickler: new pull request created: #47256 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
OSSMDOC-550: Document new WasmPlugin API.
OCP versions 4.6 - 4.11
This PR:
Link to final docs preview: http://file.bos.redhat.com/jstickle/OSSMDOC-550/service_mesh/v2x/ossm-extensions.html
Link to docs preview: https://deploy-preview-45111--osdocs.netlify.app/openshift-enterprise/latest/service_mesh/v2x/ossm-extensionsEng review - dgn, jwendell
QE review - skondkar
Peer review - jldohmann