Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHDEVDOCS-3878 - deprecation notice for Elasticsearch Operator #45184

Closed
wants to merge 1 commit into from

Conversation

libander
Copy link
Contributor

@libander libander commented Apr 29, 2022

Dev Tools

Addition of deprecation notice for Elasticsearch Operator to logging 5.4 release notes.

Version(s): main, 4.11, 4.10, 4.9, 4.8

Issue: RHDEVDOCS-3878

Preview: https://deploy-preview-45184--osdocs.netlify.app/openshift-enterprise/latest/logging/cluster-logging-release-notes.html#elasticsearch-operator-deprecation-notice

Reviewers:
Peer: @rolfedh
SME:@jcantrill
QE: N/A

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 29, 2022
@netlify
Copy link

netlify bot commented Apr 29, 2022

Deploy Preview for osdocs ready!

Name Link
🔨 Latest commit 16fb735
🔍 Latest deploy log https://app.netlify.com/sites/osdocs/deploys/626c1cac4e4529000891a737
😎 Deploy Preview https://deploy-preview-45184--osdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions. Pre-approved to expedite merging.

@@ -50,6 +50,9 @@ link:https://access.redhat.com/errata/RHSA-2022:1461[{logging-title-uc} Release

* Before this update, a change to the container logs path caused this metric to always be zero with older releases configured with the original path. With this update, the plugin which exposes metrics about collected logs supports reading from either path to resolve the issue. (link:https://issues.redhat.com/browse/LOG-2462[LOG-2462])

== Elasticsearch Operator deprecation notice
In {logging} 5.4, the Elasticsearch Operator is deprecated and is expected to be removed for the next EUS release of {product-title}. Red Hat will provide bug fixes and support for this feature during the current release lifecycle, but this feature will no longer receive enhancements and will be removed. As an alternative to using the Elasticsearch Operator to manage the default log storage, you can use the Loki Operator.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but we really need complete agreement from Jon, Shannon, and @periklis , and anyone else from program management

@@ -50,6 +50,9 @@ link:https://access.redhat.com/errata/RHSA-2022:1461[{logging-title-uc} Release

* Before this update, a change to the container logs path caused this metric to always be zero with older releases configured with the original path. With this update, the plugin which exposes metrics about collected logs supports reading from either path to resolve the issue. (link:https://issues.redhat.com/browse/LOG-2462[LOG-2462])

== Elasticsearch Operator deprecation notice
In {logging} 5.4, the Elasticsearch Operator is deprecated and is expected to be removed for the next EUS release of {product-title}. Red Hat will provide bug fixes and support for this feature during the current release lifecycle, but this feature will no longer receive enhancements and will be removed. As an alternative to using the Elasticsearch Operator to manage the default log storage, you can use the Loki Operator.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may have legal ramification of forecasting when this is removed. In most deprecation notices; that I have seen; we simply say a future release (and its our policy to make that ~2 releases out from the first notice, before complete removal).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am completely onboard in not providing and explicit timeline for deprecation. I'm more interested in putting customer's on notice that it will be dropped in future. We desperately need to not be putting Elasticsearch on the next EUS release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

In {logging} 5.4, the Elasticsearch Operator is deprecated and is planned to be removed in a future release. Red Hat will provide bug fixes and support for this feature during the current release lifecycle, but this feature will no longer receive enhancements and will be removed. As an alternative to using the Elasticsearch Operator to manage the default log storage, you can use the Loki Operator.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, guidelines for deprecation notices are here: https://redhat-documentation.github.io/supplementary-style-guide/#release-notes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcantrill - any movement on this?

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 19, 2022

@libander: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@libander
Copy link
Contributor Author

Closing - rolled into #47707

@libander libander closed this Jul 14, 2022
@libander libander deleted the RHDEVDOCS-3878-Dep-Notice branch May 2, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants