Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIG-1030: Document downstream network policy configuration compatibility with DVM #45431

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

RichardHoch
Copy link
Contributor

@RichardHoch RichardHoch commented May 9, 2022

MTC 1.7.1; OCP 4.6+

Resolves: https://issues.redhat.com/browse/MIG-1030 by adding description of configuring a DVM proxy.

Preview: This block appears in both Migrating from version 3 to 4 and Migration Toolkit for Containers in the general installation section, the section on installation in restricted environments, and the advanced migration section. Spacing and sizing are due to the screen capturing process and my desire to keep the procedure in a single capture:
dvm1
dvm2
dvm3
dvm4
dvm5

@RichardHoch RichardHoch marked this pull request as draft May 9, 2022 08:20
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 9, 2022
@netlify
Copy link

netlify bot commented May 9, 2022

Deploy Preview for osdocs ready!

Name Link
🔨 Latest commit f27a405800311e8c16876f2501fa83caf9b86f50
🔍 Latest deploy log https://app.netlify.com/sites/osdocs/deploys/628b2804dbf1cf0008da022c
😎 Deploy Preview https://deploy-preview-45431--osdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@RichardHoch RichardHoch marked this pull request as ready for review May 12, 2022 08:49
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 12, 2022
@RichardHoch RichardHoch changed the title Draft: Document downstream network policy configuration compatibility with DVM MIG-1030: Document downstream network policy configuration compatibility with DVM May 12, 2022
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2022
@eriknelson
Copy link

It feels very strange that we are redundantly surfacing the same information in 5 different places in the documentation. Does that feel like an indicator that the downstream documentation could be organized in a better manner?

@RichardHoch
Copy link
Contributor Author

@eriknelson -- I'm open to suggestions. We have 2 documents, one that focuses on migrating from OCP to 3 to 4 and one that focuses on OCP 4 to 4, so we will have some duplication no matter what. Based on the current documentation, I thought this information should be part of the installation instructions, both for restrictive and non-restrictive environments, and possibly part of the advanced migration section. If you think it does not need to be in any of these sections, please let me know.

@RichardHoch
Copy link
Contributor Author

@jldohmann I edited the file using vim. Should be OK now. Please check.

@RichardHoch
Copy link
Contributor Author

@jldohmann I fixed that last mistake. Thanks. Please don't merge yet.

@ahardin-rh ahardin-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Jun 14, 2022
@ahardin-rh ahardin-rh merged commit ad66482 into openshift:main Jun 14, 2022
@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-4.6

@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-4.7

@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-4.8

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #46661

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-4.9

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #46662

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-4.10

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #46663

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-4.11

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #46664

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #46665

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #46666

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 branch/enterprise-4.9 branch/enterprise-4.10 branch/enterprise-4.11 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants