Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Behavior of non-versioned and versioned cluster tasks #45917

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Behavior of non-versioned and versioned cluster tasks #45917

merged 1 commit into from
Jun 3, 2022

Conversation

sounix000
Copy link
Contributor

@sounix000 sounix000 commented May 23, 2022 •
edited

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 23, 2022
@netlify
Copy link

netlify bot commented May 23, 2022 •
edited

✅ Deploy Preview for osdocs ready!

Name Link
🔨 Latest commit 49c8a1fea3b8a0fa56ced977e6dd52de7861144f
🔍 Latest deploy log https://app.netlify.com/sites/osdocs/deploys/628b7d99493c50000809cdbe
😎 Deploy Preview https://deploy-preview-45917--osdocs.netlify.app/openshift-enterprise/latest/cicd/pipelines/creating-applications-with-cicd-pipelines
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rolfedh
Copy link
Contributor

rolfedh commented May 24, 2022

I have used the OpenShift Docs Peer Review Checklist to review this PR.

@sounix000
Copy link
Contributor Author

I have followed the OpenShift Docs Peer Review Checklist > For writers for writing.

rolfedh
rolfedh reviewed Jun 2, 2022
View reviewed changes
modules/op-difference-between-non-versioned-and-versioned-cluster-tasks.adoc Outdated Show resolved Hide resolved
modules/op-disabling-non-versioned-and-versioned-cluster-tasks.adoc Outdated Show resolved Hide resolved
modules/op-disabling-non-versioned-and-versioned-cluster-tasks.adoc Outdated Show resolved Hide resolved
modules/op-disabling-non-versioned-and-versioned-cluster-tasks.adoc Outdated Show resolved Hide resolved
modules/op-differences-between-non-versioned-and-versioned-cluster-tasks.adoc Outdated Show resolved Hide resolved
modules/op-differences-between-non-versioned-and-versioned-cluster-tasks.adoc Outdated Show resolved Hide resolved
modules/op-advantages-and-disadvantages-of-non-versioned-and-versioned-cluster-tasks.adoc Outdated Show resolved Hide resolved
modules/op-advantages-and-disadvantages-of-non-versioned-and-versioned-cluster-tasks.adoc Outdated Show resolved Hide resolved
modules/op-advantages-and-disadvantages-of-non-versioned-and-versioned-cluster-tasks.adoc Outdated Show resolved Hide resolved
modules/op-differences-between-non-versioned-and-versioned-cluster-tasks.adoc Outdated Show resolved Hide resolved
Behavior of non-versioned and versioned cluster tasks
7c65fb3 
intermediate content changes

checking page uilds with topc map changes

modularizing content

trying to resolve build issues

trying to fix build errors

trying to fix build errors

trying to fix build errors

trying chaning assembly name and id

intermediate commit

minor intermediate changes

intermediate commits

peer review comments

more comments

done

incorporated more peer review comments
@Preeticp Preeticp added dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs branch/enterprise-4.9 branch/enterprise-4.10 branch/enterprise-4.11 labels Jun 3, 2022
vdemeester
vdemeester approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2022
ppitonak
ppitonak approved these changes Jun 3, 2022
View reviewed changes
Copy link

@ppitonak ppitonak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Preeticp Preeticp merged commit 719bc89 into openshift:main Jun 3, 2022
@Preeticp
Copy link
Contributor

Preeticp commented Jun 3, 2022

I have used the OpenShift Docs Peer Review Checklist to merge this PR.

@Preeticp Preeticp added this to the Next Release milestone Jun 3, 2022
@Preeticp
Copy link
Contributor

Preeticp commented Jun 3, 2022

/cherrypick enterprise-4.9

@Preeticp
Copy link
Contributor

Preeticp commented Jun 3, 2022

/cherrypick enterprise-4.10

@Preeticp
Copy link
Contributor

Preeticp commented Jun 3, 2022

/cherrypick enterprise-4.11

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 3, 2022
Merged
@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #46317

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 3, 2022
Merged
@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #46318

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 3, 2022
Merged
@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #46319

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sounix000 sounix000 mentioned this pull request Jun 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Preeticp Preeticp Preeticp left review comments

@nikhil-thomas nikhil-thomas nikhil-thomas requested changes

@vdemeester vdemeester vdemeester approved these changes

@rolfedh rolfedh rolfedh approved these changes

@ppitonak ppitonak ppitonak approved these changes

Assignees

@vdemeester vdemeester

@ppitonak ppitonak

Labels
branch/enterprise-4.9 branch/enterprise-4.10 branch/enterprise-4.11 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sounix000 @rolfedh @Preeticp @openshift-cherrypick-robot @vdemeester @ppitonak @nikhil-thomas