-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSDOCS-3644 RN: installer capabilities #46411
Conversation
@jianlinliu hello Jianlin, could you please take a look at this release note for CORS-1873? I will circle back closer to GA and update the "Additional information" link once the main PR is complete. Thank you very much. |
@jinyunma @shellyyang1989 when you have time, pls help review this PR. |
@@ -100,6 +100,12 @@ For more information, see xref:../installing/installing_aws/installing-aws-secre | |||
|
|||
//For more information, see ../installing/installing_nutanix/installing-nutanix-installer-provisioned.adoc#installing-nutanix-installer-provisioned[Installing a cluster on Nutanix]. | |||
|
|||
[id="ocp-4-11-capabilities"] | |||
==== Additional customization when installing {product-title} | |||
{product-title} 4.11 allows you to disable the installation of the `metal3` API, the optional `redhat-marketplace` Operators, and the `samples` content that is stored in the `openshift` namespace. You can disable these features by setting the `baselineCapabilitySet` and `additionalEnabledCapabilities` parameters in the `install-config.yaml` configuration file prior to installation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redhat-marketplace
looks like one optional operator catalog for marketplace, see doc Red Hat-provided Operator catalogs. Maybe it is better to describe three operator names instead of its function here - baremetal, marketplace, and openshift-smaples, which also are the valid value for additionalEnabledCapabilities
.
cc: @jianzhangbjz if more comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback. I have updated the release notes to take this into account - can you please review?
I feel ^ is worth highlighting in the RN. |
286c5c6
to
13e7383
Compare
Thanks Shelly, I have added this to the end of the note. Can you please review? |
Thanks for the update! |
13e7383
to
aeee040
Compare
45d0bb3
to
86f07e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
86f07e1
to
41e0ab9
Compare
41e0ab9
to
081942e
Compare
@@ -162,6 +162,12 @@ You are no longer required to configure AWS VPC endpoints when installing a rest | |||
|
|||
For more information, see xref:../installing/installing_aws/installing-restricted-networks-aws-installer-provisioned.adoc#installation-custom-aws-vpc-requirements_installing-restricted-networks-aws-installer-provisioned[Requirements for using your VPC]. | |||
|
|||
[id="ocp-4-11-capabilities"] | |||
==== Additional customization when installing {product-title} | |||
{product-title} 4.11 allows you to disable the installation of the `baremetal` and `marketplace` Operators, and the `openshift-samples` content that is stored in the `openshift` namespace. You can disable these features by setting the `baselineCapabilitySet` and `additionalEnabledCapabilities` parameters in the `install-config.yaml` configuration file prior to installation. If you disable any of these capabilities during the installation, you can enable them after the cluster is installed. Once a capability has been enabled, it cannot be disabled again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the
openshift-samples
content that is stored in theopenshift
namespace.
Actually, they are ImageStream
resources that are managed by the sample
operator.
/lgtm |
081942e
to
f17ccc4
Compare
New changes are detected. LGTM label has been removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small things. Other than that, this LGTM!
@@ -162,6 +162,12 @@ You are no longer required to configure AWS VPC endpoints when installing a rest | |||
|
|||
For more information, see xref:../installing/installing_aws/installing-restricted-networks-aws-installer-provisioned.adoc#installation-custom-aws-vpc-requirements_installing-restricted-networks-aws-installer-provisioned[Requirements for using your VPC]. | |||
|
|||
[id="ocp-4-11-capabilities"] | |||
==== Additional customization when installing {product-title} | |||
{product-title} 4.11 allows you to disable the installation of the `baremetal` and `marketplace` Operators, and the `openshift-samples` content that is stored in the `openshift` namespace. You can disable these features by setting the `baselineCapabilitySet` and `additionalEnabledCapabilities` parameters in the `install-config.yaml` configuration file prior to installation. If you disable any of these capabilities during the installation, you can enable them after the cluster is installed. Once a capability has been enabled, it cannot be disabled again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe instead of
You can disable these features by setting the baselineCapabilitySet and additionalEnabledCapabilities parameters in the install-config.yaml
,
Try:
You can disable these features by adding the baselineCapabilitySet and additionalEnabledCapabilities parameters to the install-config.yaml
setting
makes it sounds like its going to say setting to something
Just a suggestion though, up to you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion, "adding" sounds better to me.
==== Additional customization when installing {product-title} | ||
{product-title} 4.11 allows you to disable the installation of the `baremetal` and `marketplace` Operators, and the `openshift-samples` content that is stored in the `openshift` namespace. You can disable these features by setting the `baselineCapabilitySet` and `additionalEnabledCapabilities` parameters in the `install-config.yaml` configuration file prior to installation. If you disable any of these capabilities during the installation, you can enable them after the cluster is installed. Once a capability has been enabled, it cannot be disabled again. | ||
|
||
For more information, see the "Installation configuration parameters" section of the installation documentation for your platform. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you want this Installation configuration parameters
to be a link, since this isn't a module. I know most of the other RN sections use the links
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not putting a link here since it's a platform-agnostic feature, and I'd have to link to a specific platform's page (since we don't have a configuration parameters table in our "install on any platform" page).
f17ccc4
to
de1f66c
Compare
@@ -162,6 +162,12 @@ You are no longer required to configure AWS VPC endpoints when installing a rest | |||
|
|||
For more information, see xref:../installing/installing_aws/installing-restricted-networks-aws-installer-provisioned.adoc#installation-custom-aws-vpc-requirements_installing-restricted-networks-aws-installer-provisioned[Requirements for using your VPC]. | |||
|
|||
[id="ocp-4-11-capabilities"] | |||
==== Additional customization when installing {product-title} | |||
{product-title} 4.11 allows you to disable the installation of the `baremetal` and `marketplace` Operators, and the `openshift-samples` content that is stored in the `openshift` namespace. You can disable these features by adding the `baselineCapabilitySet` and `additionalEnabledCapabilities` parameters to the `install-config.yaml` configuration file prior to installation. If you disable any of these capabilities during the installation, you can enable them after the cluster is installed. Once a capability has been enabled, it cannot be disabled again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't these be Bare Metal and Market Place Operators, since it's referring to the actual Operator?
Only use "once" when referred to time: https://www.ibm.com/docs/en/ibm-style?topic=word-usage#once
Probably swap for "When"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't these be Bare Metal and Market Place Operators, since it's referring to the actual Operator?
Only use "once" when referred to time: https://www.ibm.com/docs/en/ibm-style?topic=word-usage#once
Probably swap for "When"
I have seen the baremetal and marketplace Operators referred to in a few different ways in various places in the doc - (metal3, baremetal, Bare Metal, Baremetal, marketplace, redhat-marketplace, Red Hat Marketplace, etc). So I decided to refer to them by the same names that will be used in the actual parameters in the install-config.yaml
file (which I got from the dev doc here ).
Is it okay to say "After a capability is enabled..." to indicate that you can't disable the operator after it's been installed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the first: Sure. The inconsistency drives me insane (not here, just in general in the docs), but I can see why you chose to put those in backticks since they're part of the config YAML. That sounds good to me.
Regarding the second: Yes that sounds good to me!
de1f66c
to
51275ad
Compare
Release notes for https://issues.redhat.com/browse/CORS-1873
Doc preview: https://bscott-rh.github.io/openshift-docs/OSDOCS-3644-RN/release_notes/ocp-4-11-release-notes.html#ocp-4-11-capabilities
Doc PR: TBD