-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHDEVDOCS-3297] Minor updates to serverless ODC docs #46792
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Left one suggestion behind.
|
||
. In the *Sink* section of the *Event Sources* form view, select *Resource*. Then use the drop-down list to select your sink. | ||
. In the *Sink* section of the *Create Event Source* form view, select *Resource*. Then use the drop-down list to select your sink. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
. In the *Sink* section of the *Create Event Source* form view, select *Resource*. Then use the drop-down list to select your sink. | |
. In the *Sink* section of the *Create Event Source* form view, select *Resource*. Then use the list to select your sink. |
Per our UI guidance, we should refer to a drop-down list as simply "list". (https://docs.engineering.redhat.com/display/CCSENABLE/UI+elements)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this must be relatively new guidance because we had always previously used "drop-down" and it's used across all the serverless docs, but I will open a follow up Jira to update this in all our procedures.
It would be a bit out of scope to change this for this PR since the text wasn't added or modified for that, and it would also need to apply to a lot of other modules, and for versions as far back as 4.6 rather than just 4.8+, so I'll leave this for now but will follow it up as a batch change later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened a follow up Jira for this https://issues.redhat.com/browse/SRVCOM-1918
/cherrypick enterprise-4.8 |
/cherrypick enterprise-4.9 |
/cherrypick enterprise-4.10 |
/cherrypick enterprise-4.11 |
@abrennan89: new pull request created: #46805 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@abrennan89: new pull request created: #46806 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@abrennan89: new pull request created: #46807 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@abrennan89: new pull request created: #46808 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s):
OCP 4.8+
Issue:
https://issues.redhat.com/browse/RHDEVDOCS-3297
Link to docs preview:
Preview likely not required but can be added if necessary. This PR contains only very minor changes to text.
QE review also not required.