Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE-271: External DNS GA #46937

Merged
merged 1 commit into from
Jun 23, 2022
Merged

CFE-271: External DNS GA #46937

merged 1 commit into from
Jun 23, 2022

Conversation

xenolinux
Copy link
Contributor

@xenolinux xenolinux commented Jun 22, 2022

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 22, 2022
@@ -6,7 +6,7 @@
[id="nw-control-dns-records-public-hosted-zone-aws_{context}"]
= Creating DNS records on an public hosted zone for AWS by using Red Hat External DNS Operator

You can create DNS records on a public hosted zone for AWS by using the Red Hat External DNS Operator.
You can create DNS records on a public hosted zone for AWS by using the Red Hat External DNS Operator. You can use the same instructions to create DNS records on a public hosted zone for AWS GovCloud.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe AWS GovCloud's Route53 still doesn't support public hosted zones. So, better to not mention public for GovCloud.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed- Thanks for the review!

@alebedev87
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2022
@quarterpin
Copy link

/lgtm
thanks!

@gabriel-rh
Copy link
Contributor

This looks good to me, but need another pair of eyes from peer review squad. I added a one-page preview for convenience - https://gabriel-rh.github.io/PR46937/PR46937/networking/external_dns_operator/nw-creating-dns-records-on-aws.html

@quarterpin
Copy link

@xenolinux, one more point to be mentioned, AWS govcloud support is added as a "techpreview" in the current release of ExternalDNS operator. Rest looks fine.

@@ -6,6 +6,6 @@ include::_attributes/common-attributes.adoc[]

toc::[]

You can create DNS records on AWS using External DNS Operator.
You can create DNS records on AWS and AWS GovCloud using External DNS Operator.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can create DNS records on AWS and AWS GovCloud using External DNS Operator.
You can create DNS records on AWS and AWS GovCloud by using External DNS Operator.

Copy link
Contributor

@maxwelldb maxwelldb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion per ISG.

@maxwelldb maxwelldb added this to the Next Release milestone Jun 23, 2022
@maxwelldb maxwelldb added the peer-review-done Signifies that the peer review team has reviewed this PR label Jun 23, 2022
@maxwelldb maxwelldb merged commit 589015b into openshift:main Jun 23, 2022
@maxwelldb
Copy link
Contributor

/cherry-pick enterprise-4.10

@maxwelldb
Copy link
Contributor

/cherry-pick enterprise-4.11

@openshift-cherrypick-robot

@maxwelldb: new pull request created: #47026

In response to this:

/cherry-pick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@maxwelldb: new pull request created: #47027

In response to this:

/cherry-pick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.10 branch/enterprise-4.11 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants