-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CFE-271: External DNS GA #46937
CFE-271: External DNS GA #46937
Conversation
@@ -6,7 +6,7 @@ | |||
[id="nw-control-dns-records-public-hosted-zone-aws_{context}"] | |||
= Creating DNS records on an public hosted zone for AWS by using Red Hat External DNS Operator | |||
|
|||
You can create DNS records on a public hosted zone for AWS by using the Red Hat External DNS Operator. | |||
You can create DNS records on a public hosted zone for AWS by using the Red Hat External DNS Operator. You can use the same instructions to create DNS records on a public hosted zone for AWS GovCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe AWS GovCloud's Route53 still doesn't support public hosted zones. So, better to not mention public
for GovCloud.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed- Thanks for the review!
/lgtm |
/lgtm |
This looks good to me, but need another pair of eyes from peer review squad. I added a one-page preview for convenience - https://gabriel-rh.github.io/PR46937/PR46937/networking/external_dns_operator/nw-creating-dns-records-on-aws.html |
@xenolinux, one more point to be mentioned, AWS govcloud support is added as a "techpreview" in the current release of ExternalDNS operator. Rest looks fine. |
@@ -6,6 +6,6 @@ include::_attributes/common-attributes.adoc[] | |||
|
|||
toc::[] | |||
|
|||
You can create DNS records on AWS using External DNS Operator. | |||
You can create DNS records on AWS and AWS GovCloud using External DNS Operator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can create DNS records on AWS and AWS GovCloud using External DNS Operator. | |
You can create DNS records on AWS and AWS GovCloud by using External DNS Operator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion per ISG.
/cherry-pick enterprise-4.10 |
/cherry-pick enterprise-4.11 |
@maxwelldb: new pull request created: #47026 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@maxwelldb: new pull request created: #47027 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s): OCP 4.10+
Issue: https://issues.redhat.com/browse/CFE-271
Link to docs preview: https://gabriel-rh.github.io/PR46937/PR46937/networking/external_dns_operator/nw-creating-dns-records-on-aws.html
Additional information: