Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHDEVDOCS-3157] Add broker ODC docs #47009

Merged
merged 1 commit into from Jun 24, 2022
Merged

[RHDEVDOCS-3157] Add broker ODC docs #47009

merged 1 commit into from Jun 24, 2022

Conversation

abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Jun 23, 2022 •
edited

@abrennan89 abrennan89 added this to the Next Release milestone Jun 23, 2022
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 23, 2022
@abrennan89 abrennan89 force-pushed the RHDEVDOCS-3157 branch 2 times, most recently from 7eb2b13 to 038a7cd Compare June 24, 2022 11:31
@abrennan89 abrennan89 changed the title [WIP] [RHDEVDOCS-3157] Add broker ODC docs [RHDEVDOCS-3157] Add broker ODC docs Jun 24, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2022
@abrennan89 abrennan89 added peer-review-needed Signifies that the peer review team needs to review this PR QE Required dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs labels Jun 24, 2022
@mgencur
Copy link
Contributor

mgencur commented Jun 24, 2022

LGTM

@abrennan89 abrennan89 added qe-approved Signifies that QE has signed off on this PR and removed QE Required labels Jun 24, 2022
kelbrown20
kelbrown20 reviewed Jun 24, 2022
View reviewed changes
Copy link
Contributor

@kelbrown20 kelbrown20 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya! Just a small suggestion, feel free to discard if it messes with the context.

modules/serverless-creating-a-broker-odc.adoc Outdated Show resolved Hide resolved
@kelbrown20
Copy link
Contributor

Other than that, this LGTM! 👍

@abrennan89 abrennan89 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 24, 2022
@abrennan89 abrennan89 merged commit 3fcdf9c into openshift:main Jun 24, 2022
@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.9

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.10

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.11

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 24, 2022
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #47053

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 24, 2022
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #47054

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 24, 2022
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #47055

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89 abrennan89 deleted the RHDEVDOCS-3157 branch June 30, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelbrown20 kelbrown20 kelbrown20 left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.9 branch/enterprise-4.10 branch/enterprise-4.11 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR serverless Label for all Serverless PRs size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abrennan89 @mgencur @kelbrown20 @openshift-cherrypick-robot