OADP-481: Document supported volume types #47518
Conversation
openshift-ci
bot
added
do-not-merge/work-in-progress
RichardHoch
force-pushed
the
restic_lim
branch
2 times, most recently
from
7e2984d
to
810f0a7
Compare
RichardHoch
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
ack |
|
@sbeskin-redhat: Please review this PR. |
| @@ -10,6 +10,11 @@ You back up Kubernetes resources, internal images, and persistent volumes with R | |||
|
|
|||
| You do not need to specify a snapshot location in the `DataProtectionApplication` CR. | |||
|
|
|||
| [IMPORTANT] | |||
| ==== | |||
| Restic does not support backing up `hostPath` volumes. For more information, see link:https://velero.io/docs/v1.9/restic/#limitations[additional Rustic limitations]. | |||
There was a problem hiding this comment.
@RichardHoch
Nowb oth the Velero domain and its version will be attributes, so this link should be:
https://{velero-domain}/docs/v{velero-version}/restic/#limitations
There was a problem hiding this comment.
@sbeskin-redhat -- Will change after #47670 is merged to avoid merge conflicts. Is the rest of the PR OK?
There was a problem hiding this comment.
@sbeskin-redhat Is PR OK except for the above?
There was a problem hiding this comment.
@RichardHoch
Yes, I think so. But I would suggest you do the change now and merge the PR after 47670 is merged. Or are you going to merge this without waiting for the OADP GA?
There was a problem hiding this comment.
@sbeskin-redhat: You convinced to make the change now and to add a note above asking that this PR be merged after PR #47670. Please approve this PR.
There was a problem hiding this comment.
@RichardHoch
Looks fine
| @@ -10,6 +10,11 @@ You back up Kubernetes resources, internal images, and persistent volumes with R | |||
|
|
|||
| You do not need to specify a snapshot location in the `DataProtectionApplication` CR. | |||
|
|
|||
| [IMPORTANT] | |||
| ==== | |||
| Restic does not support backing up `hostPath` volumes. For more information, see link:https://{velero-domain}/docs/v{velero-version}/restic/#limitations[additional Rustic limitations]. | |||
There was a problem hiding this comment.
I believe this is meant to be fixed after the other PR gets merged, so ignore if that the case. But I wanted to bring up just to make sure, the link brings me to a "Page not found"
https://velero.io/docs/v%7Bvelero-version%7D/restic/#limitations
There was a problem hiding this comment.
@kelbrown20 -- yes, that's why I requested in the description that the other PR be merged first. I will change the description to make this clearer.
|
Merge review for OADP GA: Confirmed via local rebase that this URL will resolve properly now when merged. |
|
/cherrypick enterprise-4.9 |
|
/cherrypick enterprise-4.10 |
|
/cherrypick enterprise-4.11 |
|
/cherrypick enterprise-4.12 |
|
@mburke5678: new pull request created: #49903 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mburke5678: new pull request created: #49904 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mburke5678: new pull request created: #49905 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mburke5678: new pull request created: #49906 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mburke5678: new pull request created: #49917 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
OADP 1.1.0; OCP 4.9+
Resolves: https://issues.redhat.com/browse/OADP-481 by listing the volume types that Restic does not support.
Preview: http://file.emea.redhat.com/rhoch/restic_lim/backup_and_restore/application_backup_and_restore/backing_up_and_restoring/backing-up-applications.html#oadp-backing-up-applications-restic_backing-up-applications
NOTE: Please merge PR #47670 before you merge this PR -- otherwise a link in the proposed text will not work! Thanks.