Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHDEVDOCS-3972 Add content from "JNKS-289: Relocation of OpenShift Jenkins Images and what it means for you" into our docs #47660

Merged
merged 1 commit into from
Jul 21, 2022
Merged

RHDEVDOCS-3972 Add content from "JNKS-289: Relocation of OpenShift Jenkins Images and what it means for you" into our docs #47660

merged 1 commit into from
Jul 21, 2022

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Jul 11, 2022 •
edited

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 11, 2022
gabemontero
gabemontero reviewed Jul 12, 2022
View reviewed changes
Copy link
Contributor

@gabemontero gabemontero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

though this is still WIP, a quick scan reminded me of some important cross referencing with the doc that as I understood it was suppose to accompany the CPaas images in the container catalog

see comment below @coreydaley @akram @rolfedh

modules/relocation-of-openshift-jenkins-images.adoc Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 12, 2022
gabemontero
gabemontero suggested changes Jul 14, 2022
View reviewed changes
cicd/jenkins/openshift-jenkins.adoc Outdated Show resolved Hide resolved
modules/customizing-the-jenkins-image-stream-tag.adoc Outdated Show resolved Hide resolved
modules/customizing-the-jenkins-image-stream-tag.adoc Outdated Show resolved Hide resolved
modules/customizing-the-jenkins-image-stream-tag.adoc Outdated Show resolved Hide resolved
modules/customizing-the-jenkins-image-stream-tag.adoc Outdated Show resolved Hide resolved
modules/relocation-of-openshift-jenkins-images.adoc Show resolved Hide resolved
gabemontero
gabemontero suggested changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@gabemontero gabemontero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, some more potentially useful clarifications occurred to me since last time @rolfedh

make sure we get sign off from @coreydaley @akram @rgormley on this stuff as well, as they will own / maintain / interact with customers on this moving forward.

cicd/jenkins/openshift-jenkins.adoc Outdated Show resolved Hide resolved
cicd/jenkins/openshift-jenkins.adoc Outdated Show resolved Hide resolved
modules/customizing-the-jenkins-image-stream-tag.adoc Outdated Show resolved Hide resolved
modules/customizing-the-jenkins-image-stream-tag.adoc Outdated Show resolved Hide resolved
modules/relocation-of-openshift-jenkins-images.adoc Outdated Show resolved Hide resolved
modules/relocation-of-openshift-jenkins-images.adoc Outdated Show resolved Hide resolved
akram
akram suggested changes Jul 20, 2022
View reviewed changes
modules/customizing-the-jenkins-image-stream-tag.adoc Outdated Show resolved Hide resolved
modules/customizing-the-jenkins-image-stream-tag.adoc Outdated Show resolved Hide resolved
modules/relocation-of-openshift-jenkins-images.adoc Outdated Show resolved Hide resolved
modules/relocation-of-openshift-jenkins-images.adoc Outdated Show resolved Hide resolved
modules/relocation-of-openshift-jenkins-images.adoc Outdated Show resolved Hide resolved
@coreydaley
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2022
@jitendar-singh
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR and removed lgtm Indicates that a PR is ready to be merged. labels Jul 20, 2022
@akram
Copy link

akram commented Jul 20, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2022
rgormley
rgormley approved these changes Jul 20, 2022
View reviewed changes
Copy link

@rgormley rgormley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, very minor and very optional

modules/relocation-of-openshift-jenkins-images.adoc Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 20, 2022

New changes are detected. LGTM label has been removed.

@rolfedh rolfedh changed the title [WIP]RHDEVDOCS-3972 Add content from "JNKS-289: Relocation of OpenShift Jenkins Images and what it means for you" into our docs RHDEVDOCS-3972 Add content from "JNKS-289: Relocation of OpenShift Jenkins Images and what it means for you" into our docs Jul 20, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2022
jc-berger
jc-berger suggested changes Jul 20, 2022
View reviewed changes
cicd/jenkins/openshift-jenkins.adoc Outdated Show resolved Hide resolved
cicd/jenkins/openshift-jenkins.adoc Outdated Show resolved Hide resolved
cicd/jenkins/openshift-jenkins.adoc Show resolved Hide resolved
modules/customizing-the-jenkins-image-stream-tag.adoc Outdated Show resolved Hide resolved
modules/customizing-the-jenkins-image-stream-tag.adoc Outdated Show resolved Hide resolved
modules/relocation-of-openshift-jenkins-images.adoc Outdated Show resolved Hide resolved
modules/relocation-of-openshift-jenkins-images.adoc Outdated Show resolved Hide resolved
modules/relocation-of-openshift-jenkins-images.adoc Outdated Show resolved Hide resolved
modules/relocation-of-openshift-jenkins-images.adoc Outdated Show resolved Hide resolved
modules/relocation-of-openshift-jenkins-images.adoc Outdated Show resolved Hide resolved
@rolfedh
RHDEVDOCS-3972 Add content from "JNKS-289: Relocation of OpenShift Je…
ad5ee82 
…nkins Images and what it means for you" into our docs
jc-berger
jc-berger approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@jc-berger jc-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jul 21, 2022

@jc-berger: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JStickler JStickler added peer-review-done Signifies that the peer review team has reviewed this PR dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs branch/enterprise-4.11 labels Jul 21, 2022
@JStickler JStickler merged commit e9bbeb2 into openshift:main Jul 21, 2022
@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.11

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 21, 2022
Merged
@openshift-cherrypick-robot
Copy link

@JStickler: new pull request created: #48117

In response to this:

/cherry-pick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rolfedh rolfedh mentioned this pull request Jul 21, 2022
Merged
@bergerhoffer bergerhoffer added this to the Future Release milestone Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akram akram akram requested changes

@gabemontero gabemontero gabemontero requested changes

@rgormley rgormley rgormley approved these changes

@jc-berger jc-berger jc-berger approved these changes

Assignees

@akram akram

@coreydaley coreydaley

Labels
branch/enterprise-4.11 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.11 GA
Development

Successfully merging this pull request may close these issues.

None yet