Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enterprise-4.9 manual cherry-pick RN - Pipelines 1.7.2 #47893

Merged
merged 1 commit into from
Jul 19, 2022
Merged

enterprise-4.9 manual cherry-pick RN - Pipelines 1.7.2 #47893

merged 1 commit into from
Jul 19, 2022

Conversation

sounix000
Copy link
Contributor

@sounix000 sounix000 commented Jul 18, 2022

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 18, 2022
@Preeticp
Copy link
Contributor

Preeticp commented Jul 18, 2022

@sounix000 you need to add the module include statement in the assembly file for 4.9 as well for this to be rendered.

@Preeticp Preeticp added the dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs label Jul 18, 2022
@Preeticp Preeticp modified the milestone: Next Release Jul 18, 2022
review comments

final revisions

inclusion in assembly

inclusion in assembly
@Preeticp Preeticp added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2022
@Preeticp Preeticp merged commit 36b536c into openshift:enterprise-4.9 Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants