Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSDOCS-3840 Revert unsupported status of GCP workload identity in docs #47976

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

Wiharris
Copy link
Contributor

@Wiharris Wiharris commented Jul 19, 2022

OSDOCS-3840
Reverts unsupported status of GCP workload identity in docs

Versions:
PR applies only to enterprise-4.10

Issue:

Link to docs previews:

Review From:

Additional information:
This PR reverts work in #44323 now that the issue that caused OSDOCS-3445 is resolved. This entails:

Removed the admonition
Removed the module inclusion
Deleted module
Updated RN admonition.
Removed the removed feature row from the table
Removed this section under removed features
In the 4.10.8 RNs, removed the last line in this paragraph. Replaced verbiage stating the issue is resolved in 4.10.21.
Added a "New features" section to the 4.10.21 RNs. Added text announcing that the change to this feature in 4.10.8 is resolved in 4.10.21.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 19, 2022
@Wiharris Wiharris changed the title OSDOCS-3840 Revert unsupported status of GCP workload identity in docs WIP OSDOCS-3840 Revert unsupported status of GCP workload identity in docs Jul 19, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2022
@jeana-redhat jeana-redhat added this to the Next Release milestone Jul 20, 2022
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small tweaks suggested

release_notes/ocp-4-10-release-notes.adoc Outdated Show resolved Hide resolved
release_notes/ocp-4-10-release-notes.adoc Outdated Show resolved Hide resolved
release_notes/ocp-4-10-release-notes.adoc Outdated Show resolved Hide resolved
release_notes/ocp-4-10-release-notes.adoc Outdated Show resolved Hide resolved
@Wiharris Wiharris force-pushed the OSDOCS-3840 branch 2 times, most recently from b2ac61c to ab37335 Compare July 20, 2022 14:46
@Wiharris Wiharris changed the title WIP OSDOCS-3840 Revert unsupported status of GCP workload identity in docs OSDOCS-3840 Revert unsupported status of GCP workload identity in docs Jul 20, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2022
Copy link

@akhil-rane akhil-rane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2022
@kalexand-rh
Copy link
Contributor

LGTM

1 similar comment
@julienlim
Copy link

LGTM

@xltian
Copy link

xltian commented Jul 26, 2022

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2022
@sjstout
Copy link
Contributor

sjstout commented Jul 26, 2022

/lgtm

@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 26, 2022
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 26, 2022
@jeana-redhat jeana-redhat added the peer-review-done Signifies that the peer review team has reviewed this PR label Jul 26, 2022
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

OSDOCS-3840 Review 1

OSDOCS-3840 Review 2

OSDOCS-3840 Review 3

OSDOCS-3840 Review 4
@sferich888
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2022
@jeana-redhat jeana-redhat merged commit b9ac05f into openshift:enterprise-4.10 Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.10 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants