-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSDOCS-3840 Revert unsupported status of GCP workload identity in docs #47976
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple small tweaks suggested
b2ac61c
to
ab37335
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM |
1 similar comment
LGTM |
authentication/managing_cloud_provider_credentials/cco-mode-gcp-workload-identity.adoc
Show resolved
Hide resolved
/LGTM |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
OSDOCS-3840 Review 1 OSDOCS-3840 Review 2 OSDOCS-3840 Review 3 OSDOCS-3840 Review 4
/lgtm |
OSDOCS-3840
Reverts unsupported status of GCP workload identity in docs
Versions:
PR applies only to enterprise-4.10
Issue:
Link to docs previews:
Review From:
Additional information:
This PR reverts work in #44323 now that the issue that caused OSDOCS-3445 is resolved. This entails:
Removed the admonition
Removed the module inclusion
Deleted module
Updated RN admonition.
Removed the removed feature row from the table
Removed this section under removed features
In the 4.10.8 RNs, removed the last line in this paragraph. Replaced verbiage stating the issue is resolved in 4.10.21.
Added a "New features" section to the 4.10.21 RNs. Added text announcing that the change to this feature in 4.10.8 is resolved in 4.10.21.