Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHDEVDOCS-3956 - document per label scrape limit settings for UWM #48050

Merged
merged 1 commit into from Jul 22, 2022
Merged

RHDEVDOCS-3956 - document per label scrape limit settings for UWM #48050

merged 1 commit into from Jul 22, 2022

Conversation

bburt-rh
Copy link
Contributor

@bburt-rh bburt-rh commented Jul 20, 2022 •
edited

Summary: This PR updates an existing procedure to include a step describing how to configure per-label scrape limits for user workload monitoring.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 20, 2022
@bburt-rh bburt-rh force-pushed the RHDEVDOCS-3956-document-per-label-scrape-limit-settings-for-UWM branch 2 times, most recently from 9794c01 to cdd7ea8 Compare July 20, 2022 20:17
@juzhao
Copy link

juzhao commented Jul 21, 2022 •
edited

http://file.rdu.redhat.com/bburt/RHDEVDOCS-3956-document-per-label-scrape-limit-settings-for-UWM/monitoring/configuring-the-monitoring-stack.html#setting-scrape-sample-and-label-limits-for-user-defined-projects_configuring-the-monitoring-stack
Prerequisites
You have created the user-workload-monitoring-config ConfigMap object.
since 4.11, user-workload-monitoring-config ConfigMap is created by default if enabled user workload monitoring, we can change to
You have enabled monitoring for user-defined projects.

@bburt-rh bburt-rh force-pushed the RHDEVDOCS-3956-document-per-label-scrape-limit-settings-for-UWM branch 2 times, most recently from 5447204 to 8cf50dd Compare July 21, 2022 13:29
@bburt-rh
Copy link
Contributor Author

change to
You have enabled monitoring for user-defined projects.

@juzhao - Updated per your suggestion.

simonpasquier
simonpasquier reviewed Jul 21, 2022
View reviewed changes
Copy link

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bburt-rh bburt-rh force-pushed the RHDEVDOCS-3956-document-per-label-scrape-limit-settings-for-UWM branch from ffbcddd to 1b4d5a7 Compare July 22, 2022 12:50
rolfedh
rolfedh approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a couple of minor optional suggestions. Pre-approved to expedite processing.

modules/monitoring-limiting-scrape-samples-in-user-defined-projects.adoc Outdated Show resolved Hide resolved
modules/monitoring-limiting-scrape-samples-in-user-defined-projects.adoc Outdated Show resolved Hide resolved
@bburt-rh bburt-rh force-pushed the RHDEVDOCS-3956-document-per-label-scrape-limit-settings-for-UWM branch from 1b4d5a7 to 5c2abaf Compare July 22, 2022 17:56
@bburt-rh bburt-rh added peer-review-done Signifies that the peer review team has reviewed this PR dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs qe-approved Signifies that QE has signed off on this PR branch/enterprise-4.11 labels Jul 22, 2022
@bburt-rh bburt-rh merged commit 19adfb5 into openshift:main Jul 22, 2022
@bburt-rh
Copy link
Contributor Author

/cherrypick enterprise-4.11

@bburt-rh bburt-rh added this to the Future Release milestone Jul 22, 2022
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 22, 2022
Merged
@openshift-cherrypick-robot
Copy link

@bburt-rh: new pull request created: #48177

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bburt-rh bburt-rh deleted the RHDEVDOCS-3956-document-per-label-scrape-limit-settings-for-UWM branch June 6, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier left review comments

@juzhao juzhao juzhao left review comments

@rolfedh rolfedh rolfedh approved these changes

Assignees
No one assigned
Labels
branch/enterprise-4.11 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.11 GA
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bburt-rh @juzhao @openshift-cherrypick-robot @rolfedh @simonpasquier @kalexand-rh