Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSDOCS-3645]: AWS and GCP CAPI TP #48121

Merged

Conversation

jeana-redhat
Copy link
Contributor

@jeana-redhat jeana-redhat commented Jul 21, 2022

Version(s):
4.11+

Issue:
OSDOCS-3645 for OCPCLOUD-1396

Links to docs preview (require VPN):

Additional information:
Merging this will fix the build for #48234

@jeana-redhat jeana-redhat added this to the Future Release milestone Jul 21, 2022
@openshift-ci openshift-ci bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 21, 2022
@jeana-redhat jeana-redhat changed the title [OSDOCS-3645]: AWS and GCP CAPI TP WIP [OSDOCS-3645]: AWS and GCP CAPI TP Jul 21, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2022
@jeana-redhat jeana-redhat force-pushed the OSDOCS-3645-aws-gcp-capi-tp branch 2 times, most recently from 4b059b5 to 4e507ae Compare July 22, 2022 19:23
Copy link

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I left a few minor notes.

machine_management/capi-machine-management.adoc Outdated Show resolved Hide resolved
machine_management/capi-machine-management.adoc Outdated Show resolved Hide resolved
modules/capi-troubleshooting.adoc Show resolved Hide resolved
modules/capi-yaml-machine-template-aws.adoc Outdated Show resolved Hide resolved
@jeana-redhat jeana-redhat changed the title WIP [OSDOCS-3645]: AWS and GCP CAPI TP [OSDOCS-3645]: AWS and GCP CAPI TP Jul 26, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2022
@jeana-redhat jeana-redhat force-pushed the OSDOCS-3645-aws-gcp-capi-tp branch 2 times, most recently from 1d04a5e to ba141f7 Compare July 26, 2022 13:46
@jeana-redhat
Copy link
Contributor Author

@miyadav PTAL for QA

@miyadav
Copy link
Member

miyadav commented Jul 27, 2022

/lgtm .
Thanks @jeana-redhat

@jeana-redhat jeana-redhat merged commit 4d6771f into openshift:main Jul 27, 2022
@jeana-redhat
Copy link
Contributor Author

/cherrypick enterprise-4.11

@openshift-cherrypick-robot

@jeana-redhat: new pull request created: #48414

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bergerhoffer bergerhoffer added the peer-review-done Signifies that the peer review team has reviewed this PR label Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.11 peer-review-done Signifies that the peer review team has reviewed this PR size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants