Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSSMDOC-644: Update service mesh rel notes for Kiali version #48744

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

rh-tokeefe
Copy link
Contributor

@rh-tokeefe rh-tokeefe commented Aug 3, 2022

Version(s): 4.6-4.11

Issue: https://issues.redhat.com/browse/OSSMDOC-644

Link to docs preview: http://file.bos.redhat.com/tokeefe/OSSMDOC-644/service_mesh/v2x/servicemesh-release-notes.html#new-features-red-hat-openshift-service-mesh-version-2-2-1

Additional information:

Dev SME Jay Shaughnessy
QE Filip Brychta.
Peer Review: jstickler

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 3, 2022
Copy link

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the container versions are dash1 as opposed to dot1.

modules/ossm-rn-new-features.adoc Outdated Show resolved Hide resolved
modules/ossm-rn-new-features.adoc Outdated Show resolved Hide resolved
modules/ossm-rn-new-features.adoc Outdated Show resolved Hide resolved
@FilipB
Copy link

FilipB commented Aug 3, 2022

I'm wondering if it's necessary to include the last part. Is it accessible to users anywhere? Kiali operator is shown as 1.48.2 in OCP console and Kiali about dialog also shows 1.48.2.

@rh-tokeefe
Copy link
Contributor Author

rh-tokeefe commented Aug 3, 2022

@FilipB that's a good question. On prior releases, we tended to list the fourth value for additional clarity, even though the console does not show it. Including that additional digit matches the errata and the release readiness document.

@rh-tokeefe rh-tokeefe changed the title OSSMDOC-644: Update service mesh rel notes for Kial version OSSMDOC-644: Update service mesh rel notes for Kiali version Aug 3, 2022
@FilipB
Copy link

FilipB commented Aug 4, 2022

LGTM

Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JStickler JStickler merged commit 03450b6 into openshift:main Aug 8, 2022
@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.6

@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.7

@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.8

@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.9

@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.10

@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.11

@openshift-cherrypick-robot

@JStickler: new pull request created: #48849

In response to this:

/cherry-pick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@JStickler: new pull request created: #48850

In response to this:

/cherry-pick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@JStickler: new pull request created: #48851

In response to this:

/cherry-pick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@JStickler: new pull request created: #48852

In response to this:

/cherry-pick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@JStickler: new pull request created: #48853

In response to this:

/cherry-pick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@JStickler: new pull request created: #48854

In response to this:

/cherry-pick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bergerhoffer bergerhoffer added the peer-review-done Signifies that the peer review team has reviewed this PR label Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 branch/enterprise-4.9 branch/enterprise-4.10 branch/enterprise-4.11 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants