Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSSMDOC-658: Add missing steps to removing Clean up Operator Resource… #49184

Merged
merged 1 commit into from Sep 14, 2022

Conversation

rh-tokeefe
Copy link
Contributor

@rh-tokeefe rh-tokeefe commented Aug 16, 2022

…s topic

Version(s): 4.6 - 4.12

Issue: https://issues.redhat.com/browse/OSSMDOC-658

Link to docs preview: http://file.bos.redhat.com/tokeefe/OSSMDOC-658/service_mesh/v2x/removing-ossm.html

Additional information:

Fixes #49008

Dev Review: Jonh
QE Review: Matt

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 16, 2022
@mattmahoneyrh
Copy link

LGTM

@rh-tokeefe rh-tokeefe force-pushed the OSSMDOC-658 branch 3 times, most recently from 5326bef to c7cf252 Compare August 18, 2022 18:50
@rh-tokeefe rh-tokeefe force-pushed the OSSMDOC-658 branch 2 times, most recently from fdc48a4 to 5a26086 Compare August 25, 2022 13:57
@rh-tokeefe rh-tokeefe force-pushed the OSSMDOC-658 branch 2 times, most recently from 4970001 to 4430ec3 Compare September 8, 2022 17:56
@rh-tokeefe
Copy link
Contributor Author

@jwendell the revised content is now available in the preview build. When you have a moment, can you provide a quick review of the changes we discussed yesterday?

@jwendell
Copy link
Member

jwendell commented Sep 9, 2022

@jwendell the revised content is now available in the preview build. When you have a moment, can you provide a quick review of the changes we discussed yesterday?

I already approved it :)

@mattmahoneyrh
Copy link

Tested again, LGTM.

@rh-tokeefe
Copy link
Contributor Author

@JStickler dev and QE review are complete (after making a second change). We're ready for peer review when you have time, and if this looks good we can merge.

Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.6

@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.7

@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.8

@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.9

@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.10

@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.11

@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.12

@openshift-cherrypick-robot

@JStickler: new pull request created: #50421

In response to this:

/cherry-pick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@JStickler: new pull request created: #50422

In response to this:

/cherry-pick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@JStickler: new pull request created: #50423

In response to this:

/cherry-pick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@JStickler: new pull request created: #50424

In response to this:

/cherry-pick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@JStickler: new pull request created: #50425

In response to this:

/cherry-pick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@JStickler: new pull request created: #50426

In response to this:

/cherry-pick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@JStickler: new pull request created: #50427

In response to this:

/cherry-pick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enterprise-4.8] Issue in file service_mesh/v2x/removing-ossm.adoc
5 participants