Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPNET-8: Added a release note for VMware vSphere - Migrate to using unicast keepalived #49549

Merged

Conversation

ahardin-rh
Copy link
Contributor

@ahardin-rh ahardin-rh commented Aug 24, 2022

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 24, 2022
@ahardin-rh ahardin-rh force-pushed the 4-11-unicast-keepalived branch 2 times, most recently from ecdfc0c to 5981a24 Compare August 24, 2022 16:01
@ahardin-rh ahardin-rh self-assigned this Aug 24, 2022
@ahardin-rh ahardin-rh added this to the Continuous Release milestone Aug 24, 2022
@cybertron
Copy link
Member

This ended up not being specific to vsphere. Vsphere was the original driver of the change, but since we'd already been running unicast on baremetal for a while we decided to just turn it on for all on-prem platforms to reduce our support matrix, so this applies to vsphere, openstack, and ovirt.

@ahardin-rh
Copy link
Contributor Author

@cybertron Thank you! Updated.

@ahardin-rh
Copy link
Contributor Author

@qiowang721 Can you please provide QE review? Thank you!

Copy link

@jboxman-rh jboxman-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment, thanks!

@@ -646,6 +646,11 @@ For clusters that run on {rh-openstack}, the network functions virtualization de

These changes are reflected in simplified post-installation and network configuration documentation.

[id="ocp-4-11-vsphere-unicast-default"]
==== Installations on Red Hat OpenStack Platform, VMware vSphere, or oVirt now configure keepalived with unicast as the default

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahardin-rh do we want to use the attribute for OSP here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, updating now

@jboxman-rh
Copy link

@ahardin-rh, do we need a change management email about this?

@jboxman-rh jboxman-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Aug 24, 2022
@cybertron
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2022
@qiowang721
Copy link

/lgtm

@ahardin-rh
Copy link
Contributor Author

@jboxman-rh Yes, as noted above this is going through the change management process. The email is being sent out today. Thanks!

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 25, 2022

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 31, 2022
@ahardin-rh ahardin-rh merged commit f6a40d5 into openshift:enterprise-4.11 Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.11 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants