Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document a note on file permissions in projected secrets #49749

Merged
merged 1 commit into from Sep 22, 2022
Merged

Document a note on file permissions in projected secrets #49749

merged 1 commit into from Sep 22, 2022

Conversation

Srivaralakshmi
Copy link
Member

@Srivaralakshmi Srivaralakshmi commented Aug 30, 2022 •
edited

RHDEVDOCS-4255: Document a note on file permissions in projected secrets

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 30, 2022
baijum
baijum approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@baijum baijum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 30, 2022
@Srivaralakshmi
Copy link
Member Author

Hi, @dperaza4dustbit and @pmacik: PTAL at the PR and provide your feedback. Thanks!

@pmacik
Copy link
Contributor

pmacik commented Aug 30, 2022

LGMT

dperaza4dustbit
dperaza4dustbit approved these changes Aug 30, 2022
View reviewed changes
Copy link

@dperaza4dustbit dperaza4dustbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jc-berger
jc-berger approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@jc-berger jc-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Aug 30, 2022

@jc-berger: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Srivaralakshmi Srivaralakshmi changed the title [WIP] Document a note on file permissions in projected secrets Document a note on file permissions in projected secrets Sep 1, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 1, 2022
@Srivaralakshmi Srivaralakshmi changed the title Document a note on file permissions in projected secrets [WIP] Document a note on file permissions in projected secrets Sep 1, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 1, 2022
@Srivaralakshmi
Copy link
Member Author

Hi @jc-berger: Just made some updates to module file metadata, also added Anchoring IDs in module files and for Additional resources titles in assembly. No other content changes. PTAL and provide your LGTM. Thanks!

@ocpdocs-previewbot
Copy link

🤖 Bots are busy building the preview. It will be available soon at:
https://49749--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/451

@Srivaralakshmi
Copy link
Member Author

/label peer-review-done

@openshift-ci openshift-ci bot added the peer-review-done Signifies that the peer review team has reviewed this PR label Sep 19, 2022
@Srivaralakshmi
Copy link
Member Author

/label dev-tools

@openshift-ci openshift-ci bot added the dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs label Sep 19, 2022
@Srivaralakshmi Srivaralakshmi changed the title [WIP] Document a note on file permissions in projected secrets Document a note on file permissions in projected secrets Sep 22, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2022
@Srivaralakshmi
Copy link
Member Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 22, 2022
@Srivaralakshmi
Document a note on file permissions in projected secrets
8f645b0 
updates to Module file metadata, adding Anchoring IDs in module files and for Additional resources titles in assembly
@rolfedh rolfedh merged commit 0d10496 into openshift:main Sep 22, 2022
@rolfedh
Copy link
Contributor

rolfedh commented Sep 22, 2022

/cherry-pick enterprise-4.10

@rolfedh
Copy link
Contributor

rolfedh commented Sep 22, 2022

/cherry-pick enterprise-4.11

@rolfedh
Copy link
Contributor

rolfedh commented Sep 22, 2022

/cherry-pick enterprise-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 22, 2022
Merged
@openshift-cherrypick-robot
Copy link

@rolfedh: new pull request created: #50713

In response to this:

/cherry-pick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@rolfedh: new pull request created: #50714

In response to this:

/cherry-pick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Sep 22, 2022
Merged
Merged
@openshift-cherrypick-robot
Copy link

@rolfedh: new pull request created: #50715

In response to this:

/cherry-pick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh kalexand-rh removed the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfedh rolfedh rolfedh left review comments

@baijum baijum baijum approved these changes

@dperaza4dustbit dperaza4dustbit dperaza4dustbit approved these changes

@jc-berger jc-berger jc-berger approved these changes

Assignees
No one assigned
Labels
branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@Srivaralakshmi @pmacik @ocpdocs-previewbot @rolfedh @openshift-cherrypick-robot @baijum @dperaza4dustbit @jc-berger @kalexand-rh