Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update references to servicebinding.io/v1alpha3 with servicebinding.io/v1beta1 #50036

Merged
merged 1 commit into from Sep 22, 2022
Merged

Update references to servicebinding.io/v1alpha3 with servicebinding.io/v1beta1 #50036

merged 1 commit into from Sep 22, 2022

Conversation

Srivaralakshmi
Copy link
Member

@Srivaralakshmi Srivaralakshmi commented Sep 5, 2022 •
edited

RHDEVDOCS-4316: Downstream Docs - Update references to servicebinding.io/v1alpha3 with servicebinding.io/v1beta1

  • Aligned team: Dev Tools
  • OCP version for cherry-picking: enterprise-4.10, enterprise-4.11 and later
  • JIRA issues: RHDEVDOCS-4316
  • Preview pages: [Download to see the preview in your browser - 1, 2, and 3]
  • SME Review: Completed by @baijum, @dperaza4dustbit, @sadlerap
  • QE review: Completed by @pmacik
  • Peer-review: Completed by @bburt-rh

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 5, 2022
@Srivaralakshmi
Copy link
Member Author

Note to Reviewers: While raising this PR today, I ran into this build issue: https://app.travis-ci.com/github/openshift/openshift-docs/jobs/581864745#L258
PTAL at this thread. Basically, there is an error introduced in the Vale script and it will be fixed ASAP. The PR can be merged and cherry-picked as long as the other builds succeed.

@Srivaralakshmi
Copy link
Member Author

Hi, @baijum, @dperaza4dustbit, @sadlerap, and @pmacik: PTAL at the PR and provide your feedback.

baijum
baijum approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@baijum baijum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pmacik
Copy link
Contributor

pmacik commented Sep 6, 2022

LGTM

sadlerap
sadlerap approved these changes Sep 6, 2022
View reviewed changes
Copy link

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dperaza4dustbit
dperaza4dustbit approved these changes Sep 6, 2022
View reviewed changes
Copy link

@dperaza4dustbit dperaza4dustbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bburt-rh
Copy link
Contributor

bburt-rh commented Sep 8, 2022

Looks good as-is, but please rebase and re-submit the PR so that the Travis checks pass. Thanks!

@Srivaralakshmi
Copy link
Member Author

Thanks, @bburt-rh. Rebased and resubmitted the PR. PTAL.

@bburt-rh
Copy link
Contributor

bburt-rh commented Sep 8, 2022

lgtm

@Srivaralakshmi
Copy link
Member Author

@bburt-rh Please add /lgtm. Thanks!

@bburt-rh
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2022
@Srivaralakshmi Srivaralakshmi changed the title Update references to servicebinding.io/v1alpha3 with servicebinding.io/v1beta1 [WIP] Update references to servicebinding.io/v1alpha3 with servicebinding.io/v1beta1 Sep 16, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 16, 2022
@Srivaralakshmi
Copy link
Member Author

/label dev-tools
/label peer-review-done

@openshift-ci openshift-ci bot added dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs peer-review-done Signifies that the peer review team has reviewed this PR labels Sep 19, 2022
@Srivaralakshmi Srivaralakshmi changed the title [WIP] Update references to servicebinding.io/v1alpha3 with servicebinding.io/v1beta1 Update references to servicebinding.io/v1alpha3 with servicebinding.io/v1beta1 Sep 22, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2022
@Srivaralakshmi
Copy link
Member Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 22, 2022
@rolfedh rolfedh merged commit 99e4a5c into openshift:main Sep 22, 2022
@rolfedh
Copy link
Contributor

rolfedh commented Sep 22, 2022

/cherry-pick enterprise-4.10

@rolfedh
Copy link
Contributor

rolfedh commented Sep 22, 2022

/cherry-pick enterprise-4.11

@rolfedh
Copy link
Contributor

rolfedh commented Sep 22, 2022

/cherry-pick enterprise-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 22, 2022
Merged
@openshift-cherrypick-robot
Copy link

@rolfedh: new pull request created: #50716

In response to this:

/cherry-pick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@rolfedh: new pull request created: #50717

In response to this:

/cherry-pick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Sep 22, 2022
Merged
Merged
@openshift-cherrypick-robot
Copy link

@rolfedh: new pull request created: #50718

In response to this:

/cherry-pick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh kalexand-rh removed the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfedh rolfedh rolfedh left review comments

@baijum baijum baijum approved these changes

@dperaza4dustbit dperaza4dustbit dperaza4dustbit approved these changes

@sadlerap sadlerap sadlerap approved these changes

@bburt-rh bburt-rh bburt-rh approved these changes

Assignees

@bburt-rh bburt-rh

Labels
branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@Srivaralakshmi @pmacik @bburt-rh @rolfedh @openshift-cherrypick-robot @baijum @dperaza4dustbit @sadlerap @kalexand-rh