Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Release notes for SBO 1.2 #50453

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Document Release notes for SBO 1.2 #50453

merged 1 commit into from
Sep 22, 2022

Conversation

Srivaralakshmi
Copy link
Member

@Srivaralakshmi Srivaralakshmi commented Sep 15, 2022 •
edited
Loading

RHDEVDOCS-4327: Release Notes, New Features and Known Issues for SBO 1.2

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 15, 2022
@ocpdocs-previewbot
Copy link

🤖 Bots are busy building the preview. It will be available soon at:
https://50453--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/405

@Srivaralakshmi Srivaralakshmi changed the title Document Release notes for SBO 1.2 [WIP] Document Release notes for SBO 1.2 Sep 15, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 15, 2022
@Srivaralakshmi
Copy link
Member Author

Hi, @dperaza4dustbit, @sadlerap, @fbm3307, and @pmacik: PTAL at the PR and provide feedback. Thanks!

dperaza4dustbit
dperaza4dustbit reviewed Sep 15, 2022
View reviewed changes
Copy link

@dperaza4dustbit dperaza4dustbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion added

modules/sbo-release-notes-1-2.adoc Outdated Show resolved Hide resolved
@Srivaralakshmi
Copy link
Member Author

Srivaralakshmi commented Sep 16, 2022 •
edited
Loading

Note to reviewers: The content for Known Issue APPSVC-1062 exists since the last 2 releases and is already reviewed. Please review the rest of the content. Thanks!

rolfedh
rolfedh reviewed Sep 16, 2022
View reviewed changes
Copy link
Contributor

@rolfedh rolfedh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One optional style suggestion and one comment that will probably become obsolete when you update the content around line 54. Please ping me to approve this PR when you're done.

modules/sbo-release-notes-1-2.adoc Show resolved Hide resolved
modules/sbo-release-notes-1-2.adoc Outdated Show resolved Hide resolved
@pmacik
Copy link
Contributor

pmacik commented Sep 19, 2022

appart from changes suggested by @rolfedh
/lgtm

@Srivaralakshmi
Copy link
Member Author

Srivaralakshmi commented Sep 19, 2022 •
edited by openshift-ci bot
Loading

@dperaza4dustbit, @sadlerap, and @rolfedh: PTAL at the revised change to the Known issue (APPSVC-1102) and provide your feedback. Thanks!

@Srivaralakshmi
Copy link
Member Author

/label dev-tools
/label peer-review-in-progress

@openshift-ci openshift-ci bot added dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Sep 19, 2022
@Srivaralakshmi
Copy link
Member Author

/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Sep 20, 2022
dperaza4dustbit
dperaza4dustbit approved these changes Sep 20, 2022
View reviewed changes
Copy link

@dperaza4dustbit dperaza4dustbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pmacik
Copy link
Contributor

pmacik commented Sep 22, 2022

LGTM

@Srivaralakshmi
Copy link
Member Author

Hi, @gabriel-rh The Release Notes for SBO 1.2 needs to be merged today. The PR has received all the approvals from SMEs and Rolfe. However, there is a last-minute addition to the Known Issue - just one.
A quick review and approval from you would be helpful. I can then send a merge request.

@Srivaralakshmi
Copy link
Member Author

/remove-label peer-review-done

@openshift-ci openshift-ci bot removed the peer-review-done Signifies that the peer review team has reviewed this PR label Sep 22, 2022
@Srivaralakshmi
Copy link
Member Author

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Sep 22, 2022
gabriel-rh
gabriel-rh reviewed Sep 22, 2022
View reviewed changes
Copy link
Contributor

@gabriel-rh gabriel-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just a minor suggestion not to start the sentence with "But ", apart from that everything looks good to me!

modules/sbo-release-notes-1-2.adoc Outdated Show resolved Hide resolved
@Srivaralakshmi
Document Release notes for SBO 1.2
85f6e4c 
Updates to Known issues

Fixing peer review comments

Updates to known issue
@Srivaralakshmi
Copy link
Member Author

@gabriel-rh I have implemented your suggestion. PTAL and provide your LGTM. Thanks!

gabriel-rh
gabriel-rh approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@gabriel-rh gabriel-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2022
@Srivaralakshmi
Copy link
Member Author

/label peer-review-done

@openshift-ci openshift-ci bot added the peer-review-done Signifies that the peer review team has reviewed this PR label Sep 22, 2022
@Srivaralakshmi
Copy link
Member Author

/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Sep 22, 2022
@Srivaralakshmi Srivaralakshmi changed the title [WIP] Document Release notes for SBO 1.2 Document Release notes for SBO 1.2 Sep 22, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2022
@Srivaralakshmi
Copy link
Member Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 22, 2022
@rolfedh rolfedh merged commit 98d5f83 into openshift:main Sep 22, 2022
@rolfedh
Copy link
Contributor

rolfedh commented Sep 22, 2022

/cherry-pick enterprise-4.11

@rolfedh
Copy link
Contributor

rolfedh commented Sep 22, 2022

/cherry-pick enterprise-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 22, 2022
Merged
@openshift-cherrypick-robot
Copy link

@rolfedh: new pull request created: #50734

In response to this:

/cherry-pick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 22, 2022
Merged
@openshift-cherrypick-robot
Copy link

@rolfedh: new pull request created: #50735

In response to this:

/cherry-pick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh kalexand-rh removed the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmacik pmacik pmacik left review comments

@sadlerap sadlerap sadlerap left review comments

@rolfedh rolfedh rolfedh approved these changes

@dperaza4dustbit dperaza4dustbit dperaza4dustbit approved these changes

@gabriel-rh gabriel-rh gabriel-rh approved these changes

Assignees

@gabriel-rh gabriel-rh

Labels
branch/enterprise-4.11 branch/enterprise-4.12 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@Srivaralakshmi @ocpdocs-previewbot @pmacik @rolfedh @openshift-cherrypick-robot @dperaza4dustbit @sadlerap @gabriel-rh @kalexand-rh