Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to the Getting started section of OCP 4.10 docs #50470

Merged
merged 1 commit into from Sep 22, 2022
Merged

Updates to the Getting started section of OCP 4.10 docs #50470

merged 1 commit into from Sep 22, 2022

Conversation

Srivaralakshmi
Copy link
Member

@Srivaralakshmi Srivaralakshmi commented Sep 15, 2022 •
edited

RHDEVDOCS-4458: [SB] Updates to the SBO Getting started section of OCP 4.10 docs

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 15, 2022
@ocpdocs-previewbot
Copy link

🤖 Bots are busy building the preview. It will be available soon at:
https://50470--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/418

@Srivaralakshmi
Copy link
Member Author

@pmacik and @dperaza4dustbit: PTAL at the PR and provide feedback. Thanks!

@Srivaralakshmi Srivaralakshmi changed the title Updates to the Getting started section [WIP] Updates to the Getting started section of OCP 4.10 docs Sep 15, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 15, 2022
dperaza4dustbit
dperaza4dustbit approved these changes Sep 15, 2022
View reviewed changes
Copy link

@dperaza4dustbit dperaza4dustbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 16, 2022
@pmacik
Copy link
Contributor

pmacik commented Sep 19, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2022
@gabriel-rh
Copy link
Contributor

/lgtm

Looks good! The only comment I would have is about the use of the initial slash in the filespecs in the modules metadata for the "included in" adocs, but it looks like there are many other occurrences of this throughout the OpenShift docs so maybe it is not important.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 19, 2022

New changes are detected. LGTM label has been removed.

@Srivaralakshmi
Copy link
Member Author

/label peer-review-done
/label dev-tools

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs labels Sep 19, 2022
@Srivaralakshmi Srivaralakshmi changed the title [WIP] Updates to the Getting started section of OCP 4.10 docs Updates to the Getting started section of OCP 4.10 docs Sep 22, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2022
@Srivaralakshmi
Copy link
Member Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 22, 2022
@rolfedh rolfedh changed the base branch from main to enterprise-4.10 September 22, 2022 13:42
@rolfedh rolfedh changed the base branch from enterprise-4.10 to main September 22, 2022 13:43
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 22, 2022
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 22, 2022
@Srivaralakshmi Srivaralakshmi changed the base branch from main to enterprise-4.10 September 22, 2022 14:32
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 22, 2022
@Srivaralakshmi
Updates to the Getting started section
6c79bcc 
updates to module file metadata, and added Anchoring IDs in module files and for Additional resources titles in assembly

Fixing internal cross-ref

Fixing build error
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 22, 2022
@rolfedh rolfedh merged commit 93f1e85 into openshift:enterprise-4.10 Sep 22, 2022
@kalexand-rh kalexand-rh removed the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dperaza4dustbit dperaza4dustbit dperaza4dustbit approved these changes

@gabriel-rh gabriel-rh gabriel-rh approved these changes

Assignees

@pmacik pmacik

@gabriel-rh gabriel-rh

Labels
branch/enterprise-4.10 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Srivaralakshmi @ocpdocs-previewbot @pmacik @gabriel-rh @dperaza4dustbit @rolfedh @openshift-merge-robot @kalexand-rh