Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1463852 - List images required to install Openshift disconnected environment #5082

Merged
merged 1 commit into from Sep 14, 2017

Conversation

mburke5678
Copy link
Contributor

@mburke5678 mburke5678 changed the title Bug 1463852 - [DOCS] List images required to install Bug 1463852 - List images required to install Openshift disconnected environment Aug 25, 2017
@mburke5678
Copy link
Contributor Author

@mburke5678
Copy link
Contributor Author

@miheer PTAL

@mburke5678
Copy link
Contributor Author

@miheer @jianlinliu PTAL.

Miheer asked about S2I and xpass images. We have a step that lists S2I and JBoss images. It that what you are looking for?

Also, maybe this is a bad question, after downloading all the images, the user needs to add ALL of the images into tarballs?

registry.access.redhat.com/openshift3/metrics-heapster \
registry.access.redhat.com/openshift3/node \
registry.access.redhat.com/openshift3/openvswitch
----
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to provide a full list like this? Would it not be better to pull the list with a set of AIP calls?

https://mojo.redhat.com/docs/DOC-1141677

@@ -194,16 +200,26 @@ Replace `<tag>` with `{latest-int-tag}` for the latest version.
endif::[]
+
----
# docker pull registry.access.redhat.com/openshift3/container-engine:<tag>
# docker pull registry.access.redhat.com/openshift3/efs-provisioner:<tag>
# docker pull registry.access.redhat.com/openshift3/jenkins-1-rhel7:<tag>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following jenkins-* images should belong to s2i builder images, but not "components for the additional centralized log aggregation and metrics aggregation components"

# docker pull registry.access.redhat.com/openshift3/metrics-heapster:<tag>
# docker pull registry.access.redhat.com/openshift3/node:<tag>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node and openvswitch images should belong to "the required {product-title} containerized components"

@@ -194,16 +200,26 @@ Replace `<tag>` with `{latest-int-tag}` for the latest version.
endif::[]
+
----
# docker pull registry.access.redhat.com/openshift3/container-engine:<tag>
# docker pull registry.access.redhat.com/openshift3/efs-provisioner:<tag>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

container-engine and efs-provisioner images should belong to "the required {product-title} containerized components"

registry.access.redhat.com/openshift3/openvswitch
----

*Is this needed?*

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ASB depends on product registry, so in a disconnected environment, from my understanding, no need to mention this part.

----
# docker save -o ose3-logging-metrics-images.tar \
registry.access.redhat.com/openshift3/container-engine \
registry.access.redhat.com/openshift3/efs-provisioner \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just like what I mentioned in my previous comments, some images are put into wrong category.

@mburke5678
Copy link
Contributor Author

@jianlinliu Can you take another look to make sure I got your comments correct?
The original Bugzilla was filed against OCP 3.5; do the change apply for 3.6 and forward?

@jianlinliu
Copy link

The changes look good to me, but the image list I provided in the original bug is targeted for 3.6, but not 3.5, so I would say LGTM for 3.6.

@mburke5678
Copy link
Contributor Author

@jianlinliu @sferich888 Can we get a list of images for 3.5 or 3.4? is it worth the effort to go back and update those docs for the images required for Disconnected Install?

@mburke5678
Copy link
Contributor Author

@openshift/team-documentation PTAL. Updated the images required for Disconnected Install for 3.6.

@bmcelvee
Copy link
Contributor

LGTM 🌟

@mburke5678
Copy link
Contributor Author

mburke5678 commented Sep 14, 2017

[rev_history]
|xref:../install_config/install/disconnected_install.adoc#install-config-install-disconnected-install[Disconnected Installation]
|Updated the list of required and optional images to download.
%

@mburke5678 mburke5678 merged commit 48bed4c into openshift:master Sep 14, 2017
@vikram-redhat vikram-redhat modified the milestones: Next Release, Staging Sep 18, 2017
@vikram-redhat
Copy link
Contributor

@mburke5678 - there was a typo in the rev history. I have fixed it for now.

@mburke5678
Copy link
Contributor Author

See also #5272

@vikram-redhat vikram-redhat modified the milestones: Published - 18/Sep/2017, Staging Sep 24, 2017
@mburke5678 mburke5678 restored the BZ-1463852 branch September 24, 2017 22:47
@mburke5678 mburke5678 deleted the BZ-1463852 branch November 20, 2017 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants