New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1463852 - List images required to install Openshift disconnected environment #5082
Conversation
@jianlinliu @miheer Can you help with this BZ? |
@miheer PTAL |
@miheer @jianlinliu PTAL. Miheer asked about S2I and xpass images. We have a step that lists S2I and JBoss images. It that what you are looking for? Also, maybe this is a bad question, after downloading all the images, the user needs to add ALL of the images into tarballs? |
registry.access.redhat.com/openshift3/metrics-heapster \ | ||
registry.access.redhat.com/openshift3/node \ | ||
registry.access.redhat.com/openshift3/openvswitch | ||
---- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really want to provide a full list like this? Would it not be better to pull the list with a set of AIP calls?
@@ -194,16 +200,26 @@ Replace `<tag>` with `{latest-int-tag}` for the latest version. | |||
endif::[] | |||
+ | |||
---- | |||
# docker pull registry.access.redhat.com/openshift3/container-engine:<tag> | |||
# docker pull registry.access.redhat.com/openshift3/efs-provisioner:<tag> | |||
# docker pull registry.access.redhat.com/openshift3/jenkins-1-rhel7:<tag> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following jenkins-* images should belong to s2i builder images, but not "components for the additional centralized log aggregation and metrics aggregation components"
# docker pull registry.access.redhat.com/openshift3/metrics-heapster:<tag> | ||
# docker pull registry.access.redhat.com/openshift3/node:<tag> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
node and openvswitch images should belong to "the required {product-title} containerized components"
@@ -194,16 +200,26 @@ Replace `<tag>` with `{latest-int-tag}` for the latest version. | |||
endif::[] | |||
+ | |||
---- | |||
# docker pull registry.access.redhat.com/openshift3/container-engine:<tag> | |||
# docker pull registry.access.redhat.com/openshift3/efs-provisioner:<tag> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
container-engine and efs-provisioner images should belong to "the required {product-title} containerized components"
registry.access.redhat.com/openshift3/openvswitch | ||
---- | ||
|
||
*Is this needed?* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ASB depends on product registry, so in a disconnected environment, from my understanding, no need to mention this part.
---- | ||
# docker save -o ose3-logging-metrics-images.tar \ | ||
registry.access.redhat.com/openshift3/container-engine \ | ||
registry.access.redhat.com/openshift3/efs-provisioner \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just like what I mentioned in my previous comments, some images are put into wrong category.
@jianlinliu Can you take another look to make sure I got your comments correct? |
f8e9dd3
to
a31b099
Compare
The changes look good to me, but the image list I provided in the original bug is targeted for 3.6, but not 3.5, so I would say LGTM for 3.6. |
@jianlinliu @sferich888 Can we get a list of images for 3.5 or 3.4? is it worth the effort to go back and update those docs for the images required for Disconnected Install? |
@openshift/team-documentation PTAL. Updated the images required for Disconnected Install for 3.6. |
LGTM 🌟 |
[rev_history] |
@mburke5678 - there was a typo in the rev history. I have fixed it for now. |
See also #5272 |
https://bugzilla.redhat.com/show_bug.cgi?id=1463852