Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNV-20080: Ending VNC session #51349

Merged
merged 1 commit into from
Oct 18, 2022
Merged

CNV-20080: Ending VNC session #51349

merged 1 commit into from
Oct 18, 2022

Conversation

apinnick
Copy link
Contributor

@apinnick apinnick commented Oct 6, 2022 •
edited

Version(s): 4.8+

Issue: CNV-20080

Link to docs preview: Connecting to VNC Console

QE review: @gouyang

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 6, 2022
@ocpdocs-previewbot
Copy link

🤖 Bots are busy building the preview. It will be available soon at:
https://51349--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/1386

@apinnick apinnick marked this pull request as ready for review October 6, 2022 12:34
@apinnick apinnick requested a review from gouyang October 6, 2022 12:35
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2022
@gouyang
Copy link

gouyang commented Oct 8, 2022

LGTM

@apinnick apinnick added peer-review-needed Signifies that the peer review team needs to review this PR and removed QE Required labels Oct 18, 2022
sjhala-ccs
sjhala-ccs reviewed Oct 18, 2022
View reviewed changes
Copy link
Contributor

@sjhala-ccs sjhala-ccs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjhala-ccs sjhala-ccs added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 18, 2022
@apinnick apinnick merged commit aab1eac into openshift:main Oct 18, 2022
@apinnick
Copy link
Contributor Author

/cherrypick enterprise-4.8

@apinnick
Copy link
Contributor Author

/cherrypick enterprise-4.9

@apinnick
Copy link
Contributor Author

/cherrypick enterprise-4.10

@apinnick
Copy link
Contributor Author

/cherrypick enterprise-4.11

@apinnick
Copy link
Contributor Author

/cherrypick enterprise-4.12

@apinnick apinnick deleted the CNV-20080-exit-vnc-console branch October 18, 2022 13:37
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 18, 2022
Merged
@openshift-cherrypick-robot
Copy link

@apinnick: new pull request created: #51782

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 18, 2022
Merged
@openshift-cherrypick-robot
Copy link

@apinnick: new pull request created: #51783

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 18, 2022
Merged
@openshift-cherrypick-robot
Copy link

@apinnick: new pull request created: #51784

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 18, 2022
Merged
@openshift-cherrypick-robot
Copy link

@apinnick: new pull request created: #51785

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 18, 2022
Merged
@openshift-cherrypick-robot
Copy link

@apinnick: new pull request created: #51786

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjhala-ccs sjhala-ccs sjhala-ccs left review comments

@gouyang gouyang Awaiting requested review from gouyang

Assignees
No one assigned
Labels
branch/enterprise-4.8 branch/enterprise-4.9 branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@apinnick @ocpdocs-previewbot @gouyang @openshift-cherrypick-robot @sjhala-ccs