OADP-717: OADP 1.0.x & OCP 4.11 compatibility issue #51355
Conversation
openshift-ci
bot
added
the
size/S
|
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/3681 |
|
/lgtm |
snippets/oadp-ocp-compat.adoc
Outdated
| :_content-type: SNIPPET | ||
| [NOTE] | ||
| ==== | ||
| OADP 1.0._x_ does not support CSI backup on OCP 4.11+. because Velero 1.7.x, which ships with OADP 1.0._x_, expects the API group `snapshot.storage.k8s.io/v1beta1`,` which is not present on OCP 4.11+. |
There was a problem hiding this comment.
There's an extraneous back-tick after the comma that should be removed.
| OADP 1.0._x_ does not support CSI backup on OCP 4.11+. because Velero 1.7.x, which ships with OADP 1.0._x_, expects the API group `snapshot.storage.k8s.io/v1beta1`,` which is not present on OCP 4.11+. | |
| OADP 1.0._x_ does not support CSI backup on OCP 4.11+. OADP 1.0._x_ ships Velero 1.7.x and expects the API group `snapshot.storage.k8s.io/v1beta1`, which is not present on OCP 4.11+. |
There was a problem hiding this comment.
Fixed; ""ships" changed to "includes" due to style guide.
RichardHoch
force-pushed
the
oadp_ocp_compat
branch
from
a8087dd
to
5e76239
Compare
|
oadp |
|
/oadp |
|
/OADP |
|
OADP |
|
/label OADP |
|
@RichardHoch: Can not set label oadp: Must be member in one of these teams: [team-red-hat] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@RichardHoch: Can not set label peer-review-needed: Must be member in one of these teams: [team-red-hat] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kalexand-rh
added
peer-review-needed
|
/label peer-review-in-progress |
openshift-ci
bot
added
the
peer-review-in-progress
|
Looks good to me, Richard. No changes added. |
|
/remove-label peer-review-in-progress |
openshift-ci
bot
added
peer-review-done
RichardHoch
force-pushed
the
oadp_ocp_compat
branch
from
5e76239
to
3fdcef6
Compare
|
New changes are detected. LGTM label has been removed. |
RichardHoch
force-pushed
the
oadp_ocp_compat
branch
from
0c4962d
to
faf95ac
Compare
RichardHoch
force-pushed
the
oadp_ocp_compat
branch
from
faf95ac
to
13b397d
Compare
|
/label merge-review-needed |
openshift-ci
bot
added
the
merge-review-needed
|
OADP 1.1.1 GA is 28 November. |
jboxman-rh
added
merge-review-in-progress
|
@RichardHoch, should this not be merged until that time? Thanks! |
|
@jboxman-rh -- That is my understanding; I will double-check but please don't merge yet. Thanks for asking! |
|
@jboxman-rh please merge this |
|
/OADP |
|
/cherry-pick enterprise-4.12 |
|
@jboxman-rh: new pull request created: #53234 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick enterprise-4.11 |
|
@jboxman-rh: new pull request created: #53239 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
OADP 1.1.1 and OADP 1.0.x; OCP 4.11+
Dev and QE review complete. OCP peer review complete and Avital's suggestion implemented.
Resolves https://issues.redhat.com/browse/OADP-717 by adding a note to the sections shown in the previews.
Previews:
See note in https://51355--docspreview.netlify.app/openshift-enterprise/latest/backup_and_restore/index.html#oadp-requirements
See 2nd note in https://51355--docspreview.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/about-installing-oadp.html