Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHDEVDOCS-4410 - Doc: Resource type updates-Import from Git & deploy image #51733

Merged
merged 1 commit into from Nov 4, 2022
Merged

RHDEVDOCS-4410 - Doc: Resource type updates-Import from Git & deploy image #51733

merged 1 commit into from Nov 4, 2022

Conversation

smunje1
Copy link
Contributor

@smunje1 smunje1 commented Oct 17, 2022 •
edited

RHDEVDOCS-4410: Doc: Resource type updates-Import from Git & deploy image

Aligned team: Dev Tools
OCP version for cherry-picking: enterprise-4.12
JIRA issues: RHDEVDOCS-4410
Preview pages: Download to see the preview in your browser
SME Review: @divyanshiGupta
QE review: @sanketpathak
Peer-review: @sounix000

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 17, 2022
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 17, 2022 •
edited

🤖 Updated build preview is available at:
https://51733--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/3017

@smunje1
Copy link
Contributor Author

smunje1 commented Oct 17, 2022 •
edited

Hello @divyanshiGupta
Could you help with the SME review for this PR?

Thank you!

@smunje1
Copy link
Contributor Author

smunje1 commented Oct 19, 2022

Hello @divyanshiGupta. I have incorporated your feedback.
Could you please have a look and confirm?

Thank you!

@divyanshiGupta
Copy link

LGTM.

@smunje1
Copy link
Contributor Author

smunje1 commented Oct 21, 2022

Hello @sanketpathak
Could you help with the QE review for this PR?

Thank you!

@smunje1
Copy link
Contributor Author

smunje1 commented Oct 31, 2022

Hello @sanketpathak
Could you help me understand if you got a chance to look into this PR?

Thank you!

@sanketpathak
Copy link

LGTM

@smunje1
Copy link
Contributor Author

smunje1 commented Nov 4, 2022

@sounix000 Thanks for your suggestion. I have incorporated your feedback. Please confirm and send your approval.

After the updates, a screenshot:
image

@sounix000
Copy link
Contributor

LGTM

@smunje1
Copy link
Contributor Author

smunje1 commented Nov 4, 2022

After the updates, a screenshot:
image

@bburt-rh Thanks for your suggestion. Very good catch. Could you please take a look now?

Thank you!

@bburt-rh bburt-rh added peer-review-done Signifies that the peer review team has reviewed this PR dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs qe-approved Signifies that QE has signed off on this PR branch/enterprise-4.12 labels Nov 4, 2022
@bburt-rh bburt-rh added this to the Planned for 4.12 GA milestone Nov 4, 2022
@bburt-rh bburt-rh merged commit 868e369 into openshift:main Nov 4, 2022
@bburt-rh
Copy link
Contributor

bburt-rh commented Nov 4, 2022

/cherrypick enterprise-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 4, 2022
Merged
@openshift-cherrypick-robot
Copy link

@bburt-rh: new pull request created: #52497

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@smunje1 smunje1 mentioned this pull request Nov 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyanshiGupta divyanshiGupta divyanshiGupta left review comments

@sounix000 sounix000 sounix000 left review comments

@bburt-rh bburt-rh bburt-rh left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.12 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.12 GA
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@smunje1 @ocpdocs-previewbot @divyanshiGupta @sanketpathak @sounix000 @bburt-rh @openshift-cherrypick-robot