-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CFE-473: Add information about profiling data lifetime #52213
Conversation
ab8449d
to
1a8060f
Compare
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/3093 |
Thanks for the PR, @xenolinux ! Just a small proposal.
|
2ef9def
to
73f5174
Compare
@@ -6,7 +6,7 @@ | |||
[id="running-profiling-query_{context}"] | |||
= Running the profiling query | |||
|
|||
To run the profiling query, you must create a `NodeObservabilityRun` resource. The profiling query is a blocking operation that fetches CRI-O and Kubelet profiling data for a duration of 30 seconds. After the profiling query is complete, you must retrieve the profiling data inside the container file system `/run/node-observability` directory. | |||
To run the profiling query, you must create a `NodeObservabilityRun` resource. The profiling query is a blocking operation that fetches CRI-O and Kubelet profiling data for a duration of 30 seconds. After the profiling query is complete, you must retrieve the profiling data in the `emptyDir` volume. You can access the profiling data as long as a pod is in the `running` status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To run the profiling query, you must create a `NodeObservabilityRun` resource. The profiling query is a blocking operation that fetches CRI-O and Kubelet profiling data for a duration of 30 seconds. After the profiling query is complete, you must retrieve the profiling data in the `emptyDir` volume. You can access the profiling data as long as a pod is in the `running` status. | |
To run the profiling query, you must create a `NodeObservabilityRun` resource. The profiling query is a blocking operation that fetches CRI-O and Kubelet profiling data for a duration of 30 seconds. After the profiling query is complete, you must retrieve the profiling data inside the container file system `/run/node-observability` directory. The data's life time is bound to the agent pod via the `emptyDir` volume, so you can access the profiling data as long as a pod is in the `running` status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed
73f5174
to
df60e1b
Compare
/lgtm |
/lgtm |
df60e1b
to
678d64f
Compare
New changes are detected. LGTM label has been removed. |
/label peer-review-needed |
/label peer-review-in-progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except a minor comment!
/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done
@@ -6,7 +6,7 @@ | |||
[id="running-profiling-query_{context}"] | |||
= Running the profiling query | |||
|
|||
To run the profiling query, you must create a `NodeObservabilityRun` resource. The profiling query is a blocking operation that fetches CRI-O and Kubelet profiling data for a duration of 30 seconds. After the profiling query is complete, you must retrieve the profiling data inside the container file system `/run/node-observability` directory. | |||
To run the profiling query, you must create a `NodeObservabilityRun` resource. The profiling query is a blocking operation that fetches CRI-O and Kubelet profiling data for a duration of 30 seconds. After the profiling query is complete, you must retrieve the profiling data inside the container file system `/run/node-observability` directory. The lifetime of data is bound to the agent pod through the `emptyDir` volume, so you can access the profiling data as long as the agent pod is in the `running` status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refer to ISG > Word Usage for as long as
To run the profiling query, you must create a `NodeObservabilityRun` resource. The profiling query is a blocking operation that fetches CRI-O and Kubelet profiling data for a duration of 30 seconds. After the profiling query is complete, you must retrieve the profiling data inside the container file system `/run/node-observability` directory. The lifetime of data is bound to the agent pod through the `emptyDir` volume, so you can access the profiling data as long as the agent pod is in the `running` status. | |
To run the profiling query, you must create a `NodeObservabilityRun` resource. The profiling query is a blocking operation that fetches CRI-O and Kubelet profiling data for a duration of 30 seconds. After the profiling query is complete, you must retrieve the profiling data inside the container file system `/run/node-observability` directory. The lifetime of data is bound to the agent pod through the `emptyDir` volume, so you can access the profiling data while the agent pod is in the `running` status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed
678d64f
to
e8957a7
Compare
/label merge-review-needed |
/cherrypick enterprise-4.12 |
1 similar comment
/cherrypick enterprise-4.12 |
@mjpytlak: new pull request created: #52556 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s): 4.12+
Issue: https://issues.redhat.com/browse/CFE-473
Link to docs preview: http://file.rdu.redhat.com/sdudhgao/nob-data-profiling/scalability_and_performance/node-observability-operator.html#running-profiling-query_node-observability-operator
QE review:
Additional information: