CFE-650: ALBO supports k8s service resource types using NLB #52309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
size/XS
xenolinux
changed the title
|
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/4011 |
thejasn
reviewed
Nov 3, 2022
| @@ -11,6 +11,8 @@ The AWS Load Balancer Operator can tag the public subnets if the `kubernetes.io/ | |||
|
|
|||
| * Public and private subnets of the discovered VPC. | |||
|
|
|||
| The AWS Load Balancer Operator supports the Kubernetes service resource type `LoadBalancer` by using Network Load Balancer (NLB) with the `instance` or the `ip` target type. | |||
There was a problem hiding this comment.
Suggested change
| The AWS Load Balancer Operator supports the Kubernetes service resource type `LoadBalancer` by using Network Load Balancer (NLB) with the `instance` or the `ip` target type. | |
| The AWS Load Balancer Operator supports the Kubernetes service resource type `LoadBalancer` by using Network Load Balancer (NLB) with the `instance` target type only. |
xenolinux
force-pushed
the
albo-network-load-balancer
branch
from
0756fc1
to
cd575f1
Compare
|
@lihongan Would you please review this PR? |
xenolinux
added
the
peer-review-needed
|
/label peer-review-in-progress |
openshift-ci
bot
added
peer-review-in-progress
|
/remove-label peer-review-in-progress |
openshift-ci
bot
added
peer-review-done
|
Looks good. Thank you @xenolinux |
xenolinux
added
merge-review-needed
alebedev87
reviewed
Nov 23, 2022
| @@ -11,6 +11,8 @@ The AWS Load Balancer Operator can tag the public subnets if the `kubernetes.io/ | |||
|
|
|||
| * Public and private subnets of the discovered VPC. | |||
|
|
|||
| The AWS Load Balancer Operator supports the Kubernetes service resource type `LoadBalancer` by using Network Load Balancer (NLB) with the `instance` target type only. | |||
There was a problem hiding this comment.
Suggested change
| The AWS Load Balancer Operator supports the Kubernetes service resource type `LoadBalancer` by using Network Load Balancer (NLB) with the `instance` target type only. | |
| The AWS Load Balancer Operator supports the Kubernetes service resource of type `LoadBalancer` by using Network Load Balancer (NLB) with the `instance` target type only. |
xenolinux
force-pushed
the
albo-network-load-balancer
branch
from
cd575f1
to
31aa0e5
Compare
|
/lgtm |
xenolinux
added
the
merge-review-needed
snarayan-redhat
added
the
merge-review-in-progress
|
/cherrypick enterprise-4.12 |
|
@snarayan-redhat: new pull request created: #53131 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version(s): 4.12+
Issue: https://issues.redhat.com/browse/CFE-650
Link to docs preview: https://52309--docspreview.netlify.app/openshift-enterprise/latest/networking/aws_load_balancer_operator/understanding-aws-load-balancer-operator.html#nw-aws-load-balancer-operator_aws-load-balancer-operator
QE review:
Additional information: