Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSSMDOC-720: Add more detail to Gateway API enablement docs #52324

Merged
merged 1 commit into from Nov 16, 2022
Merged

OSSMDOC-720: Add more detail to Gateway API enablement docs #52324

merged 1 commit into from Nov 16, 2022

Conversation

rh-tokeefe
Copy link
Contributor

@rh-tokeefe rh-tokeefe commented Oct 31, 2022 •
edited

Version(s): 4.9 - 4.12

Issue: https://issues.redhat.com/browse/OSSMDOC-720

Link to docs preview: http://file.bos.redhat.com/tokeefe/OSSMDOC-720/service_mesh/v2x/servicemesh-release-notes.html

QE review:

  • QE has approved this change.

Additional information:

QA Review: Matt Mahoney
Dev: Jacek /Daniel
Peer: Brian B

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 31, 2022
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 31, 2022 •
edited

🤖 Updated build preview is available at:
https://52324--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/3642

@mattmahoneyrh
Copy link

LGTM

1 similar comment
@pbajjuri20
Copy link

LGTM

dgn
dgn reviewed Nov 1, 2022
View reviewed changes
Copy link

@dgn dgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should mention that the Gateway API CRDs do not come pre-installed by default, so will have to be installed prior to enabling support in the SMCP. See step 1 in the upstream docs. This is important as OSSM can't start up if you enable Gateway API support but don't install the CRDs.

Also, we could add an example on how you can link an existing gateway to a Gateway resource (upstream docs show this under "Manual Deployment")

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 1, 2022
@rh-tokeefe
Copy link
Contributor Author

@dgn and @jewertow I've made some updates based on your comments. Please review.

@rh-tokeefe
Copy link
Contributor Author

All developer comments have been addressed. PR ready for peer review.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2022
@bburt-rh
Copy link
Contributor

bburt-rh commented Nov 7, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 15, 2022

New changes are detected. LGTM label has been removed.

@bburt-rh bburt-rh added peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR labels Nov 16, 2022
@bburt-rh bburt-rh added this to the Continuous Release milestone Nov 16, 2022
@bburt-rh bburt-rh merged commit 9a68c58 into openshift:main Nov 16, 2022
@bburt-rh
Copy link
Contributor

/cherrypick enterprise-4.9

@bburt-rh
Copy link
Contributor

/cherrypick enterprise-4.10

@bburt-rh
Copy link
Contributor

/cherrypick enterprise-4.11

@bburt-rh
Copy link
Contributor

/cherrypick enterprise-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 16, 2022
Merged
@openshift-cherrypick-robot
Copy link

@bburt-rh: new pull request created: #52892

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 16, 2022
Merged
@openshift-cherrypick-robot
Copy link

@bburt-rh: new pull request created: #52893

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 16, 2022
Merged
@openshift-cherrypick-robot
Copy link

@bburt-rh: new pull request created: #52894

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 16, 2022
Merged
@openshift-cherrypick-robot
Copy link

@bburt-rh: new pull request created: #52895

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bburt-rh bburt-rh bburt-rh approved these changes

@dgn dgn dgn approved these changes

@jewertow jewertow jewertow approved these changes

Assignees

@bburt-rh bburt-rh

Labels
branch/enterprise-4.9 branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR service-mesh Label for all Service Mesh PRs size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@rh-tokeefe @ocpdocs-previewbot @mattmahoneyrh @pbajjuri20 @bburt-rh @openshift-cherrypick-robot @dgn @jewertow @rolfedh