Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHDEVDOCS-4541: Adding default prunner configuration #52847

Merged
merged 1 commit into from
Nov 18, 2022
Merged

RHDEVDOCS-4541: Adding default prunner configuration #52847

merged 1 commit into from
Nov 18, 2022

Conversation

sounix000
Copy link
Contributor

@sounix000 sounix000 commented Nov 16, 2022 •
edited

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 16, 2022
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 16, 2022 •
edited

🤖 Updated build preview is available at:
https://52847--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/3784

pradeepitm12
pradeepitm12 reviewed Nov 16, 2022
View reviewed changes
Copy link

@pradeepitm12 pradeepitm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2022
gabriel-rh
gabriel-rh reviewed Nov 17, 2022
View reviewed changes
Copy link
Contributor

@gabriel-rh gabriel-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - some minor sugestions

modules/op-default-prunner-configuration.adoc Outdated Show resolved Hide resolved
modules/op-default-prunner-configuration.adoc Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 18, 2022
RHDEVDOCS-4541: Adding default pronner configuration
3efcfea 
minor addition

modified snippet

Pradeep's comments

Veeresh's comments

Peer reiew comments

updated snippet
gabriel-rh
gabriel-rh approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@gabriel-rh gabriel-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2022
@gabriel-rh gabriel-rh added branch/enterprise-4.11 branch/enterprise-4.12 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs labels Nov 18, 2022
@gabriel-rh gabriel-rh merged commit d703f09 into openshift:main Nov 18, 2022
@gabriel-rh
Copy link
Contributor

/cherry-pick enterprise-4.11

@gabriel-rh
Copy link
Contributor

/cherry-pick enterprise-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 18, 2022
Merged
@openshift-cherrypick-robot
Copy link

@gabriel-rh: new pull request created: #52975

In response to this:

/cherry-pick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 18, 2022
Merged
@openshift-cherrypick-robot
Copy link

@gabriel-rh: new pull request created: #52976

In response to this:

/cherry-pick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VeereshAradhya VeereshAradhya VeereshAradhya left review comments

@pradeepitm12 pradeepitm12 pradeepitm12 left review comments

@ppitonak ppitonak ppitonak approved these changes

@gabriel-rh gabriel-rh gabriel-rh approved these changes

Assignees

@pradeepitm12 pradeepitm12

@gabriel-rh gabriel-rh

Labels
branch/enterprise-4.11 branch/enterprise-4.12 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sounix000 @ocpdocs-previewbot @gabriel-rh @openshift-cherrypick-robot @ppitonak @VeereshAradhya @pradeepitm12