-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OCPBUGS-3341] Add RHOSP CCM options reference documentation #53068
[OCPBUGS-3341] Add RHOSP CCM options reference documentation #53068
Conversation
@MaysaMacedo @rlobillo This is brand new and not yet situated in the docs, but the module should be ready for a first look if you have time. Related to: #52294 |
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/6926 |
@MaysaMacedo: GitHub didn't allow me to request PR reviews from the following users: for, confirming. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Should this same doc be included since 4.9? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny remark.
Added docs preview link. |
7ef689e
to
ba4da5a
Compare
@MaysaMacedo I included those in the "these exist but you should not modify them" section at the bottom of the page based on one of @stephenfin's comments. If you think that they're unhelpful or misleading to include, though, I could pull them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replied. This is looking better with just a few small comments outstanding.
Co-authored-by: Jon Uriarte <juriarte@redhat.com>
lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
New changes are detected. LGTM label has been removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wheeee tables. Just a few small things from me, and a couple questions to evaluate. Otherwise LGTM!
/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done
Co-authored-by: Jeana Routh <61474374+jeana-redhat@users.noreply.github.com>
/cherry-pick enterprise-4.12 |
@maxwelldb: #53068 failed to apply on top of branch "enterprise-4.12":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s):
4.12
Issue:
OCPBUGS-3341
Link to docs preview: https://53068--docspreview.netlify.app/openshift-enterprise/latest/installing/installing_openstack/installing-openstack-cloud-config-reference.html
QE review:
Additional information: Need to figure out where to put this. It would bloat the installation assemblies. Possible options:
Will link from installation assemblies to this one after this is merged.